http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4123 Summary: Error in checking whether a checkout can be renewed Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Circulation AssignedTo: gmcharlt@gmail.com ReportedBy: oleonard@myacpl.org Estimated Hours: 0.0 Change sponsored?: --- In Circulation.pm, part of sub CanBookBeRenewed: ----------------------------------------------- SELECT borrowers.categorycode, biblioitems.itemtype, issues.renewals, renewalsallowed, $controlbranch FROM issuingrules, issues LEFT JOIN items USING (itemnumber) LEFT JOIN borrowers USING (borrowernumber) LEFT JOIN biblioitems USING (biblioitemnumber) WHERE issuingrules.categorycode = borrowers.categorycode AND issuingrules.itemtype = $itype AND (issuingrules.branchcode = $controlbranch OR issuingrules.branchcode = '*') AND borrowernumber = ? AND itemnumber = ? ORDER BY issuingrules.categorycode desc, issuingrules.itemtype desc, issuingrules.branchcode desc LIMIT 1; ----------------------------------------------- I see that there is a check for a wildcard under issuingrules.branchcode. Should there not be a similar check with issuingrules.categorycode and issuingrules.itemtype? i.e. (issuingrules.categorycode = borrowers.categorycode OR issuingrules.categorycode = '*') (issuingrules.itemtype = $itype OR issuingrules.itemtype = '*') Without the wildcard option doesn't that mean you have to have a rule set up for each patron category/itemtype combination? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.