[Bug 3785] New: New Install, no maxreserves setting, OPAC holds fail
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3785 Summary: New Install, no maxreserves setting, OPAC holds fail Product: Koha Version: rel_3_0 Platform: PC OS/Version: Windows 2000 Status: NEW Severity: normal Priority: P3 Component: Hold requests AssignedTo: gmcharlt@gmail.com ReportedBy: jwagner@ptfs.com Estimated Hours: 0.0 Change sponsored?: --- On a new git install, if the site has not set any value in the maxreserves syspref, trying to place a hold through the OPAC results in a blank screen. There is no visible error message, but the error log says: opac-reserve.pl: Argument "" isn't numeric in numeric ge (>=) at /home/servername/kohaclone/opac/opac-reserve.pl line 265. When I look at line 265 in opac-reserve.pl, here's the code block: if ( scalar(@reserves) >= $MAXIMUM_NUMBER_OF_RESERVES ) { $template->param( message => 1 ); $noreserves = 1; $template->param( too_many_reserves => scalar(@reserves)); } Setting a numeric value in the syspref made holds work OK, but the code needs to be fixed so that it accounts for a null or empty entry. How best to do that? I'm not sure what section of code to check, to see if staff-side holds has the same problem. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3785 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |henridamien@koha-fr.org, | |nengard@gmail.com Severity|normal |critical OS/Version|Windows 2000 |All Version|rel_3_0 |HEAD --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2009-12-07 15:45:22 --- upping priority - the fact that you can't place holds and that this is missing are big deals. Also changing version - this is the issue in the current HEAD version. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3785 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Priority|P3 |PATCH-Sent -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3785 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |chris@bigballofwax.co.nz Status|NEW |ASSIGNED --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2009-12-15 23:21:24 --- Created an attachment (id=1349) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1349) Patch -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3785 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.edu --- Comment #3 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-02-01 16:48:05 --- It seems that this syspref should be done away with and opac-reserve.pl be made to obey the issuerules. In turn, there should be a 'standard' default rule to fall back on. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3785 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Severity|critical |major --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> 2010-04-30 12:22:44 --- Pushed the C4/ILSDI/Utility.pm portion of Chris Cormack's patch to HEAD. Commit 6e376d04 by Chris Nighswonger, pushed earlier, handled the opac-reserve.pl part. Recommend leaving open because of Chris Nighswonger's comment about the need to replace the system preference with a check of the issuingrules, but downgrading to major. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com