[Bug 23934] New: Item level holds not checked for LocalHoldsPriority in Holds Queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Bug ID: 23934 Summary: Item level holds not checked for LocalHoldsPriority in Holds Queue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18001 Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001 [Bug 18001] LocalHoldsPriority can cause multiple holds queue lines for same hold request -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 94908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94908&action=edit Bug 23934: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94908|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 94923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94923&action=edit Bug 23934: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 94924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94924&action=edit Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94923|0 |1 is obsolete| | Attachment #94924|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 94926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94926&action=edit Bug 23934: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94926|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 94929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94929&action=edit Bug 23934: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 94930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94930&action=edit Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Test plan: - Set LocalHoldsPriority to "Give priority for filling holds to patrons whose pickup library matches the item's holding library" - set yourself at Library A - find at item at Library A - place an item-level hold (Hold 1) for item for pickup at Library B - set an item-level hold (Hold 2) for item for pickup at Library A - Confirm Hold 1 shows priority=1 - Check in item - confirm item would be captured for Hold 2, ignore hold - run holds queue - check item in - confirm item is captured for Hold 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94930|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96163&action=edit Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94929|0 |1 is obsolete| | Attachment #96163|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97196&action=edit Bug 23934: Unit test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97197&action=edit Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue Test plan: - Set LocalHoldsPriority to "Give priority for filling holds to patrons whose pickup library matches the item's holding library" - set yourself at Library A - find at item at Library A - place an item-level hold (Hold 1) for item for pickup at Library B - set an item-level hold (Hold 2) for item for pickup at Library A - Confirm Hold 1 shows priority=1 - Check in item - confirm item would be captured for Hold 2, ignore hold - run holds queue - check item in - confirm item is captured for Hold 2 Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- unit tests do not apply cleanly to 19.05.x branch, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org