[Bug 25517] New: Translation of item/items in availability on staff search results broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Bug ID: 25517 Summary: Translation of item/items in availability on staff search results broken Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Depends on: 22422 Bug 22422 introduced this to the staff search results: [% tnx('{count} item', '{count} items', SEARCH_RESULT.items_count, {count = SEARCH_RESULT.items_count}) | html %][% IF ( SEARCH_RESULT.availablecount ) %], [% SEARCH_RESULT.availablecount | html %] available:[% ELSE %], None available[% END %] But this doesn't appear to get applied, although the strings are translated in the po file. Might also affect other versions, but I couldn't verify. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 [Bug 22422] improve item location display with class "shelvingloc" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22422 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 [Bug 22422] improve item location display with class "shelvingloc" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21789 Summary|Translation of item/items |[18.11] Translation of |in availability on staff |item/items in availability |search results broken |on staff search results | |broken Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21789 [Bug 21789] Example usage of I18N Template::Toolkit plugin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, it does translate when I reinstall the language in my dev environment. I wonder if this could be related to the packages and the update process? I know translations are automatically updated when you install a new package. Is there a reson why this would not work for the new messages file? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is probably a WONTFIX because of the old version (we will still investigate a bit more and I will share if we find out something useful) The problem we encountered is that after several updates via packages the strings still appeared untranslated, although po files were in place. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, still seeing issues there on our package based installation. Still investigating and trying to get it to translate. Note the changed dependency, this is related to bug 21789. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Ever confirmed|1 |0 Summary|[18.11] Translation of |Translation of item/items |item/items in availability |in availability on staff |on staff search results |search results broken |broken | Status|RESOLVED |UNCONFIRMED CC| |julian.maurice@biblibre.com Version|18.11 |unspecified --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We finally found a solution: Koha/I18N.pm looks for the Koha.mo in the wrong path for package based installations. It works fine on git, gitified etc. but not for an installatione done from packages. We solved it for now by creating a symlink. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ulrich.kleiber@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translation of item/items |Koha.mo not found on |in availability on staff |pacakge installations / |search results broken |Translations not working Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Needs to be confirmed for other versions than 18.11, but I18N.pm hasn't changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Alpha packages are currently building for 20.05.. let's verify if this is still a bug with those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #6)
Alpha packages are currently building for 20.05.. let's verify if this is still a bug with those.
Thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha.mo not found on |Koha.mo not found on |pacakge installations / |package installations / |Translations not working |Translations not working -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- sub _base_directory { return C4::Context->config('intranetdir') . '/misc/translator/po'; } but debian/templates/koha-conf-site.xml.in: <intranetdir>/usr/share/koha/intranet/cgi-bin</intranetdir> And POs are in /usr/share/koha/misc/translator/po -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Joubu, that's exactly the problem we've seen. Now hoping it can be fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 105270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105270&action=edit Bug 25517: Look in all possible places for MO files On a 'dev' install, MO files will be installed in <intranetdir>/misc/translator/po On 'standard' and 'single' installs, they will be installed in <intranetdir>/../../misc/translator/po This patch makes Koha::I18N try to use the "dev" directory first, and fallback to the "standard" directory. If none of these directories exist, it dies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This might be more of a quick fix as noted in the FIXME. But given we are a bit short of time to the release we might want to consider it. I am doing a regression test as I can't test on a package installation myself, so take the sign-off with that grain of salt! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105270|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105276&action=edit Bug 25517: Look in all possible places for MO files On a 'dev' install, MO files will be installed in <intranetdir>/misc/translator/po On 'standard' and 'single' installs, they will be installed in <intranetdir>/../../misc/translator/po This patch makes Koha::I18N try to use the "dev" directory first, and fallback to the "standard" directory. If none of these directories exist, it dies. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Passing QA.. local testing proved fruitful. Thanks for the quick fix.. lets see if there's a nicer way as part of the next cycle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Version(s)|20.05.00, 19.11.07 |20.05.00, 19.11.07, released in| |19.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org