[Bug 33615] New: Date picker icon not visible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Bug ID: 33615 Summary: Date picker icon not visible Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikapark@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Noticed on the Edit item screen and the Issues screen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #1 from wainuiwitikapark@catalyst.net.nz --- Aleisha did a git bisect to see what caused the issue 854c0fc1dea9435e35832a5190847aa7f922335e is the first bad commit commit 854c0fc1dea9435e35832a5190847aa7f922335e Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Wed Jan 11 15:20:28 2023 +0100 Bug 32609: Remove CSS and JS compiled files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (cherry picked from commit dcf772cb7026b4ed21caf6b055f8260140dcefdb) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> koha-tmpl/intranet-tmpl/prog/css/calendar.css | 9 --------- koha-tmpl/intranet-tmpl/prog/css/holds.css | 1 - koha-tmpl/intranet-tmpl/prog/css/installer.css | 9 --------- koha-tmpl/intranet-tmpl/prog/css/mainpage.css | 1 - koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 9 --------- koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/print-rtl.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/print.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/sco.css | 1 - 11 files changed, 35 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/calendar.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/holds.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/installer.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/mainpage.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/staff-global.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/opac.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/print-rtl.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/print.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sco.css -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |22.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32609 CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32978 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32978 CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I think bug 32978 might be the root cause of this one. As I noted on bug 33621 it looks like the problem is that a hash (ie #) isn't being encoded when it should be. I think the fix is probably to change fill='#369' to fill='%23369' in ./koha-tmpl/opac-tmpl/bootstrap/css/src/_flatpickr.scss Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978 [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 150261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150261&action=edit pic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to David Cook from comment #2)
I think bug 32978 might be the root cause of this one.
As I noted on bug 33621 it looks like the problem is that a hash (ie #) isn't being encoded when it should be.
I think the fix is probably to change fill='#369' to fill='%23369' in ./koha-tmpl/opac-tmpl/bootstrap/css/src/_flatpickr.scss
this seems to have fixed the problem, tested in master (pic attached) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 150262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150262&action=edit Bug 33615: Date picker icon not visible to test: - apply patch, build package - edit item, observe calendar icon is visible -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Version|22.11 |unspecified Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The patch fixes the problem but I don't understand why the problem has been caused by bug 32609. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Cook from comment #2)
I think bug 32978 might be the root cause of this one.
I reverted e5b28d9c40cab651079eadc1b64d2479a34cbbeb && yarn install && yarn css:build => no icon -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #7)
(In reply to David Cook from comment #2)
I think bug 32978 might be the root cause of this one.
I reverted e5b28d9c40cab651079eadc1b64d2479a34cbbeb && yarn install && yarn css:build => no icon
I'm not familiar enough with the process but perhaps a person needs to remove all node_modules and all built files as well? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150262|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 150315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150315&action=edit Bug 33615: Date picker icon not visible to test: - apply patch, build package - edit item, observe calendar icon is visible Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. In the staff interface, edit and item for a record. 2. Note that there is no calendar icon in the 'd - Date acquired' input field. 3. Apply the patch. 4. Rebuild: yarn build 5. Restart all the things: flush_memecached, restart_all 6. Repeat step 1 (refresh the page if required). 7. There is now a calendar icon in the date acquired field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150315|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 150323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150323&action=edit Bug 33615: Date picker icon not visible to test: - apply patch, build package - edit item, observe calendar icon is visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org