[Bug 33631] New: results_summary label and content are slightly misaligned in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Bug ID: 33631 Summary: results_summary label and content are slightly misaligned in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: lucas@bywatersolutions.com Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If you look at the results_summary on either the results or detail pages you will notice that the label and content are slightly misaligned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150307&action=edit Bug 33631: Fix alignment issue in results_summary To test: 1 On staff results or detail page notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150307|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 150314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150314&action=edit Bug 33631: Fix alignment issue in results_summary To test: 1 On staff results or detail page notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Thanks Lucas for reporting and fixing this! I also noticed some ISBD view labels are slightly misaligned (see for example biblionumber=262 Programming Perl). I can log a separate bug for this if you like. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #3)
Thanks Lucas for reporting and fixing this!
I also noticed some ISBD view labels are slightly misaligned (see for example biblionumber=262 Programming Perl). I can log a separate bug for this if you like.
David, I am going to provide an alternative patch that will fix both. I think we can eliminate the vertical-align rule altogether. It will effect all label (element) and .label ( class ) in Koha so it will require a bit more thourough testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150320&action=edit Bug 33631: [alternate] Fix misaligned labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass from comment #4)
(In reply to David Nind from comment #3)
Thanks Lucas for reporting and fixing this!
I also noticed some ISBD view labels are slightly misaligned (see for example biblionumber=262 Programming Perl). I can log a separate bug for this if you like.
David,
I am going to provide an alternative patch that will fix both. I think we can eliminate the vertical-align rule altogether. It will effect all label (element) and .label ( class ) in Koha so it will require a bit more thourough testing.
Back to NSO for such testing :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Keywords| |rel_22_11_candidate --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We've also seen this - happy to have a look! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150453&action=edit k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150320|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150454&action=edit Bug 33631: [alternate] Fix misaligned labels If you look at the results_summary on either the results or detail pages you will notice that the label and content are slightly misaligned. To test: 1. On staff results, detail page, or ISBD details notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150453|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've fixed the commit message :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #11 from David Nind <david@davidnind.com> --- Thanks for testing and signing off Katrin! (You beat me to it!) I was working through various screens, but had not found anything - so far, any misalignments I found were already there before the patch. This also now corrects the display in the search results. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please sign-off, then I can use my token for QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150454|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 150465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150465&action=edit Bug 33631: [alternate] Fix misaligned labels If you look at the results_summary on either the results or detail pages you will notice that the label and content are slightly misaligned. To test: 1. On staff results, detail page, or ISBD details notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #14 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #12)
Please sign-off, then I can use my token for QA :)
Done! I also tested a sample of other pages to see if I noticed any changes (this was in no way comprehensive). I only identified some minor misalignments that were present before the patch was applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org