http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11482&action=edit Bug 8606 - Talking Tech broken by Bug 7001 The patches for bug 7001 removed the parseletter subroutine from C4::Letters without updating the talking tech script to use the new alternative. This patch rectifies that situation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11482|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11483&action=edit Bug 8606 - Talking Tech broken by Bug 7001 The patches for bug 7001 removed the parseletter subroutine from C4::Letters without updating the talking tech script to use the new alternative. This patch rectifies that situation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11483|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11830&action=edit Bug 8606 - Talking Tech broken by Bug 7001 The patches for bug 7001 removed the parseletter subroutine from C4::Letters without updating the talking tech script to use the new alternative. This patch rectifies that situation. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: No side effect possible. I don't tested the patch but it seems good. No blocker: * C4/Letters.pm FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (156) But I don't understand why do you use the | operator. I think you wanted to use the || operator and wrote $branchcode ||= ''; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12359|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12360&action=edit Bug 8606 - Talking Tech broken by user-configurable slips feature - QA Followup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #7)

You are correct. The smallest followup ever written has been attached ; )

Thank you Kyle. So I mark it as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Severity|enhancement |normal --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master I thin it's more a bugfix than en ENH. Switching to "normal" severity, probably expected for 3.8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.