http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: No side effect possible. I don't tested the patch but it seems good. No blocker: * C4/Letters.pm FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (156) But I don't understand why do you use the | operator. I think you wanted to use the || operator and wrote $branchcode ||= ''; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.