[Bug 20499] New: Checkout of bad barcode: Internal Server Error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Bug ID: 20499 Summary: Checkout of bad barcode: Internal Server Error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com There is no error checking on whether the barcode was found. Add some to prevent this internal server error. Can't call method "biblioitem" on an undefined value at /home/vagrant/kohaclone/C4/Circulation.pm line 673. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73439&action=edit Bug 20499: Unit Test to prove the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Circulation.t -- horrible death. 3) apply next path 4) prove t/db_dependent/Circulation.t -- passes. 5) run koha qa test tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73440&action=edit Bug 20499: Fix the Internal Server Error TEST PLAN --------- See comment #1 Applying the test without the patch: messy. Applyin both patches: smooth. Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- The location of the test was chosen, because it is where the first occurrence of CanBookBeIssued is. Feel free to move it elsewhere if needed. But the fix is the fix. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73440|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73442&action=edit Bug 20499: Fix the Internal Server Error TEST PLAN --------- See comment #1 Applying the test without the patch: messy. Applyin both patches: smooth. Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |19943 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 6183c0e6a910663fec02bdba66d05f173310f562 Bug 19943: Koha::Biblio - Replace GetBiblioItemData with Koha::Biblio->biblioitem Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 [Bug 19943] Koha::Biblio - Remove GetBiblioItemData -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73439|0 |1 is obsolete| | Attachment #73442|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74107&action=edit Bug 20499: Unit Test to prove the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Circulation.t -- horrible death. 3) apply next path 4) prove t/db_dependent/Circulation.t -- passes. 5) run koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74108&action=edit Bug 20499: Fix the Internal Server Error TEST PLAN --------- See comment #1 Applying the test without the patch: messy. Applyin both patches: smooth. Run koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74109&action=edit Bug 20499: just check if GetItem returns something is enough Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- '"KohaIsAwesome" is not a valid barcode. Mark: Formally, this is an assumption :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74107|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74144&action=edit Bug 20499: Unit Test to prove the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Circulation.t -- horrible death. 3) apply next path 4) prove t/db_dependent/Circulation.t -- passes. 5) run koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74108|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74145&action=edit Bug 20499: Fix the Internal Server Error TEST PLAN --------- See comment #1 Applying the test without the patch: messy. Applyin both patches: smooth. Run koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74109|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74146&action=edit Bug 20499: just check if GetItem returns something is enough Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Dependency not in stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org