[Bug 19882] New: Add Novelist Select staff client profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Bug ID: 19882 Summary: Add Novelist Select staff client profile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The novelist in the staff client doesn't form links correctly as the profile refers to the OPAC. Novelist has suggested a separate profile for the staff side would allow better styling and correct linking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11606 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 [Bug 11606] Novelist Select in Staff Client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70171&action=edit Bug 19882 - Add Novelist Select staff client profile This patchset allows for use of a separate Novelist profile for the staff client and opac. This allows Novelist to determine links and special styling for each. Testing is best with novelist credentials, however, confirming that values are set and used correctly and nothing is broken should suffice. To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records on opac and staff client and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displayed and nothing is displayed if not 7 - Repeat with all staff view options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |victor.grousset@biblibre.co | |m --- Comment #2 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- conflicts: ~/d/koha ❯❯❯ git bz apply 19882 Bug 19882 - Add Novelist Select staff client profile 70171 - Bug 19882 - Add Novelist Select staff client profile Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19882 - Add Novelist Select staff client profile Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging installer/data/mysql/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 19882 - Add Novelist Select staff client profile The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19882---Add-Novelist-Select-staff-client-profi-lR7BtR.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70171|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72718&action=edit Bug 19882 - Add Novelist Select staff client profile This patchset allows for use of a separate Novelist profile for the staff client and opac. This allows Novelist to determine links and special styling for each. Testing is best with novelist credentials, however, confirming that values are set and used correctly and nothing is broken should suffice. To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records on opac and staff client and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displayed and nothing is displayed if not 7 - Repeat with all staff view options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I tested this with my library's Novelist credentials and it's working well. The only problem I see is a fail from the QA tools: [% KOHA_VERSION %] is removed by the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72718|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72882&action=edit Bug 19882 - Add Novelist Select staff client profile This patchset allows for use of a separate Novelist profile for the staff client and opac. This allows Novelist to determine links and special styling for each. Testing is best with novelist credentials, however, confirming that values are set and used correctly and nothing is broken should suffice. To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records on opac and staff client and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displayed and nothing is displayed if not 7 - Repeat with all staff view options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72718|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #4)
The only problem I see is a fail from the QA tools: [% KOHA_VERSION %] is removed by the patch.
I think this fail is a bug in the qa tools. We don't use [% KOHA_VERSION %] with third-party assets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72718|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72918&action=edit Bug 19882 - Add Novelist Select staff client profile This patchset allows for use of a separate Novelist profile for the staff client and opac. This allows Novelist to determine links and special styling for each. Testing is best with novelist credentials, however, confirming that values are set and used correctly and nothing is broken should suffice. To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records on opac and staff client and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displayed and nothing is displayed if not 7 - Repeat with all staff view options Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 72918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72918 Bug 19882 - Add Novelist Select staff client profile Review of attachment 72918: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19882&attachment=72918) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ +1025,5 @@
verify_images(); });[% END %] </script> + [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && ( normalized_isbn || normalized_upc ) ) %] + <script type="text/javascript" src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script>
External Javascript, so this is ok. FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL forbidden patterns forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 1049) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72918|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74084&action=edit Bug 19882: Add Novelist Select staff client profile This patchset allows for use of a separate Novelist profile for the staff client and opac. This allows Novelist to determine links and special styling for each. Testing is best with novelist credentials, however, confirming that values are set and used correctly and nothing is broken should suffice. To test: 1 - Apply patches 2 - Update database 3 - View detail pages for some records on opac and staff client and ensure no changes have been made 4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile and password) 5 - Set NovelistSelectStaffView to 'above' 6 - View detail pages for some records, verify that if novelist info is available it is displayed and nothing is displayed if not 7 - Repeat with all staff view options Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. IGNORE is missing (I can do it when pushing, but...) 2. We should set NovelistSelectStaffProfile=NovelistSelectProfile, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74103&action=edit Bug 19882: (follow-up) Add 'IGNORE' in DB update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- 1 - Added :-) 2 - That is the problem right now - using the regular profile makes all links point over to the opac and so they don't work properly. I can add to the release notes as I think disabling it until they add a profile is better -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new Staff release notes| |Client profile for Novelist | |information. Previously we | |used the same value as the | |opac, this caused malformed | |links on the staff side. | |With this patch Novelist | |features will be disabled | |on the staff client until a | |correct profile is obtained | |from Novelist and entered | |into the system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74239&action=edit Bug 19882: Fix syntax issue in .pref file The translate script raised an error: Use of uninitialized value $pref_name in concatenation (.) or string at LangInstaller.pm line 190. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backported for 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org