[Bug 28933] New: Hard to parse OPAC-detail subscription information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 Bug ID: 28933 Summary: Hard to parse OPAC-detail subscription information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org I received a request to hide all closed subscriptions from the OPAC detail subscriptions tab. When a subscription is closed a '.subscription_closed' class is added, which is great. The problem there is no hierarchy to the HTML structure, every subscription detail (.subscription_closed, .subscription_location, etc. ) is a sibling of the next. It would be trivial to add a parent element to each subscription to make it easier to target with CSS/jQuery. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 124314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124314&action=edit Bug 28933: Add subscription class to each subscription in opac-detail To Test: 1. Go to a record with some subscriptions, have some closed and some open. 2. Go to the opac-detail page, click on the subscription tab and use your developer tools to inscept the element. 3. Notice the hierarchy of HTML structure, everything is a sibling of the next. 4. Apply patch 5. Reload the same opac-detail page and again inscept the element. 6. Now every individual subscription should be wrapped in an element with the class name of 'subscription'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124314|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124436&action=edit Bug 28933: Add subscription class to each subscription in opac-detail To Test: 1. Go to a record with some subscriptions, have some closed and some open. 2. Go to the opac-detail page, click on the subscription tab and use your developer tools to inscept the element. 3. Notice the hierarchy of HTML structure, everything is a sibling of the next. 4. Apply patch 5. Reload the same opac-detail page and again inscept the element. 6. Now every individual subscription should be wrapped in an element with the class name of 'subscription'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124436|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125321&action=edit Bug 28933: Add subscription class to each subscription in opac-detail To Test: 1. Go to a record with some subscriptions, have some closed and some open. 2. Go to the opac-detail page, click on the subscription tab and use your developer tools to inscept the element. 3. Notice the hierarchy of HTML structure, everything is a sibling of the next. 4. Apply patch 5. Reload the same opac-detail page and again inscept the element. 6. Now every individual subscription should be wrapped in an element with the class name of 'subscription'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org