[Bug 29030] New: Problems introduced by bugg 25728
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Bug ID: 29030 Summary: Problems introduced by bugg 25728 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: klas.blomberg@skovde.se QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl There are two problems with the feature of creating new authorized values introduced by bugg 25728 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 The MINOR problem is that you can save a new authorized value without actually entering a new authorized value, you just need a description The MAJOR problem is that this feature isn't optional! Introducing a new authorized value is a complex process where you have to take library limitaions into consideration, authorized values are used in sysprefs and conjobs, often you have to rewrite some reports when you introduce a new authorized value &c, &c. In short: We certainly don't want anyone to create new authorized values on the fly! Not even I should have that possibility. We have had this unwelcome feature for some weeks, and there are already dozens of new athorized values created by mistake. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- At the very least the authorized value and description fields should be mandatory in the modal form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Problems introduced by bugg |Problems introduced by bug |25728 |25728 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124905&action=edit Bug 29030: Make authorized value and description fields required This patch modifies the markup of the "Create a new authorized value" modal so that a minimum set of fields is required: Authorized value and description. The patch also modifies the JavaScript which handles the submission so that the jQuery Validation plugin can handle the field checks. The spelling "authorised" is changed to "authorized" following coding guidelines. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate a record in the catalog which has items and open an item for editing. - In the add item form, test the process of adding an authorized value on the fly with the following fields: Withdrawn, Lost, Damaged, Use restrictions, Not for loan, Collection code, Shelving location, and Shelving control number. - In each case you should be able to type a new value in the dropdown's search box and be shown the option "Select to create." - Selecting should trigger a modal window, "Create a new authorized value." - Test that both "Authorized value" and "Description" fields are required, and the form can't be submitted without them. - Test that an error message shows up when you submit an authorized value which already exists, e.g. authval "1" for "DAMAGED." - After triggering this error, click the "Cancel" button and try creating another new authorized value. When the modal reopens the form should be reset: No previously-entered data, no error messages. - Submitting a valid form with a new authorized value should work correctly. The modal window should close automatically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #1)
At the very least the authorized value and description fields should be mandatory in the modal form.
My patch makes this change along with some other interface improvements. It would be nice if errors triggered by duplicate authorized values were better handled... Right now it triggers a 500 error which shows up in the browser console. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124905|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 124920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124920&action=edit Bug 29030: Make authorized value and description fields required This patch modifies the markup of the "Create a new authorized value" modal so that a minimum set of fields is required: Authorized value and description. The patch also modifies the JavaScript which handles the submission so that the jQuery Validation plugin can handle the field checks. The spelling "authorised" is changed to "authorized" following coding guidelines. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate a record in the catalog which has items and open an item for editing. - In the add item form, test the process of adding an authorized value on the fly with the following fields: Withdrawn, Lost, Damaged, Use restrictions, Not for loan, Collection code, Shelving location, and Shelving control number. - In each case you should be able to type a new value in the dropdown's search box and be shown the option "Select to create." - Selecting should trigger a modal window, "Create a new authorized value." - Test that both "Authorized value" and "Description" fields are required, and the form can't be submitted without them. - Test that an error message shows up when you submit an authorized value which already exists, e.g. authval "1" for "DAMAGED." - After triggering this error, click the "Cancel" button and try creating another new authorized value. When the modal reopens the form should be reset: No previously-entered data, no error messages. - Submitting a valid form with a new authorized value should work correctly. The modal window should close automatically. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124920|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125337&action=edit Bug 29030: Make authorized value and description fields required This patch modifies the markup of the "Create a new authorized value" modal so that a minimum set of fields is required: Authorized value and description. The patch also modifies the JavaScript which handles the submission so that the jQuery Validation plugin can handle the field checks. The spelling "authorised" is changed to "authorized" following coding guidelines. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate a record in the catalog which has items and open an item for editing. - In the add item form, test the process of adding an authorized value on the fly with the following fields: Withdrawn, Lost, Damaged, Use restrictions, Not for loan, Collection code, Shelving location, and Shelving control number. - In each case you should be able to type a new value in the dropdown's search box and be shown the option "Select to create." - Selecting should trigger a modal window, "Create a new authorized value." - Test that both "Authorized value" and "Description" fields are required, and the form can't be submitted without them. - Test that an error message shows up when you submit an authorized value which already exists, e.g. authval "1" for "DAMAGED." - After triggering this error, click the "Cancel" button and try creating another new authorized value. When the modal reopens the form should be reset: No previously-entered data, no error messages. - Submitting a valid form with a new authorized value should work correctly. The modal window should close automatically. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Error display change: Before: https://snipboard.io/oGy94Y.jpg After : https://snipboard.io/cN1FnV.jpg Looks better! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Klas, is this patch answering your need? If not, please open a new bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Margaret Hade <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 [Bug 29137] Unwanted authorised values are too easily created via the cataloging module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org