http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32821&action=edit Bug 13152 - Duplicate phone hold notices when using Talking Tech If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. Test Plan: 1) Enable Talking Tech from the system preferences 2) Set a hold waiting phone notice in the notices and slips editor 3) Choose a patron, enable hold phone notices for that patron 4) Place a hold for a patron, and check it in so it's marked as waiting 5) Note the phone notice generated for the patron 6) Apply this patch 7) Repeat step 4 8) Note that this time, a phone hold waiting notice is not generated -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32821|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32823&action=edit Bug 13152 - Duplicate phone hold notices when using Talking Tech If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. Test Plan: 1) Enable Talking Tech from the system preferences 2) Set a hold waiting phone notice in the notices and slips editor 3) Choose a patron, enable hold phone notices for that patron 4) Place a hold for a patron, and check it in so it's marked as waiting 5) Note the phone notice generated for the patron 6) Apply this patch 7) Repeat step 4 8) Note that this time, a phone hold waiting notice is not generated -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13152 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33917|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33926&action=edit [PASSED QA] Bug 13152 - Duplicate phone hold notices when using Talking Tech If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. Test Plan: 1) Enable Talking Tech from the system preferences 2) Set a hold waiting phone notice in the notices and slips editor 3) Choose a patron, enable hold phone notices for that patron 4) Place a hold for a patron, and check it in so it's marked as waiting 5) Note the phone notice generated for the patron 6) Apply this patch 7) Repeat step 4 8) Note that this time, a phone hold waiting notice is not generated Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amends condition with an additional or statement. Shoudn't affect anything but phone notices. Change appears logical. -- You are receiving this mail because: You are watching all bug changes.