http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.8 |master Summary|OPAC Status Display |Show damaged status in the |hierarchy |OPAC for items which are | |not for loan Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32047&action=edit Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by amber@marlboro.edu <1> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32048|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 32050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32050&action=edit Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation This minor follow-up revises the language a bit: Adding missing question marks and using the more standard prompt "Please select at least one..." To test, follow the previous test plan and confirm that the prompts are improved: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: amber@marlboro.edu <1> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32047|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32049|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32047|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32160&action=edit Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32048|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32161&action=edit Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan This patch contains the compiled opac.css file generated from the revised LESS file in this bug's other patch. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32160|0 |1 is obsolete| | Attachment #32161|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32269&action=edit Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32269|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33463&action=edit Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.