[Bug 12989] New: Update table footer with the visible rows - acqui-home
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Bug ID: 12989 Summary: Update table footer with the visible rows - acqui-home Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12988 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |12984, 12986 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31856&action=edit Bug 12989: Update table footer with the visible rows - acqui-home Note that bug 12984 changes the view of this table. On the acqui-home page, the total was not updated. With this patch, the footer (totals) will be updated on filtering rows. Test plan: 1/ Go on the acqui home page. 2/ Verify the totals are correct. 3/ Filter the table using the filter input and verify the totals are updated with the rows shown. 4/ Hide/Show inactive budgets and verify the totals are still corrects. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12986 |12987 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31977&action=edit Bug 12989: Fix JS error inactive and active are not defined anymore. They should be removed. The filter is done with DataTables. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31856|0 |1 is obsolete| | Attachment #31977|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32149&action=edit Bug 12989: Update table footer with the visible rows - acqui-home Note that bug 12984 changes the view of this table. On the acqui-home page, the total was not updated. With this patch, the footer (totals) will be updated on filtering rows. Test plan: 1/ Go on the acqui home page. 2/ Verify the totals are correct. 3/ Filter the table using the filter input and verify the totals are updated with the rows shown. 4/ Hide/Show inactive budgets and verify the totals are still corrects. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32150&action=edit Bug 12989: Fix JS error inactive and active are not defined anymore. They should be removed. The filter is done with DataTables. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12984 Depends on|12984 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32149|0 |1 is obsolete| | --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 32348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32348&action=edit Bug 12989: Update table footer with the visible rows - acqui-home I've applied the patches against master 3.17.00.027 I've applied (see also bug 12988): 0001-Bug-12979-Price-formatting-should-only-be-defined-at.patch 0002-Bug-12979-Fix-error-on-layout3pagesfr.patch 0003-Bug-12844-New-module-to-manage-prices-into-Koha.patch 0004-Bug-12844-Remove-the-C4-Output-FormatNumber-subrouti.patch 0005-Bug-12844-Use-Koha-Number-Price-where-it-can-be-usef.patch 0006-Bug-12844-FIX-import-package-missing.patch 0007-Bug-12844-Force-the-symbol-place-in-the-tests.patch 0008-Bug-12955-The-show-my-funds-only-should-be-take-into.patch 0009-Bug-12986-Upgrade-the-DataTables-jQuery-plugin-to-th.patch 0010-Bug-12987-Update-table-footer-with-the-visible-rows.patch 0011-Bug-12987-The-new-format_price-include-file-should-b.patch 0012-Bug-12988-Update-table-footer-with-the-visible-rows-.patch 0013-Bug-12984-Improvement-of-the-funds-list-view-acqui-h.patch 0014-Bug-12989-Update-table-footer-with-the-visible-rows-.patch 0015-Bug-12989-Fix-JS-error.patch I've tested setting either FR or US currencyformat syspref. Everything is OK. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32150|0 |1 is obsolete| | --- Comment #6 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 32349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32349&action=edit Bug 12989: Fix JS error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32348|0 |1 is obsolete| | Attachment #32349|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32817&action=edit [PASSED QA] Bug 12989: Update table footer with the visible rows - acqui-home Note that bug 12984 changes the view of this table. On the acqui-home page, the total was not updated. With this patch, the footer (totals) will be updated on filtering rows. Test plan: 1/ Go on the acqui home page. 2/ Verify the totals are correct. 3/ Filter the table using the filter input and verify the totals are updated with the rows shown. 4/ Hide/Show inactive budgets and verify the totals are still corrects. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32818&action=edit [PASSED QA] Bug 12989: Fix JS error inactive and active are not defined anymore. They should be removed. The filter is done with DataTables. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12984 | Depends on| |12984 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org