[Bug 26314] New: "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Bug ID: 26314 Summary: "Volumes: show volumes" showing regardless of whether there are volumes linked to the record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 15851 When cataloguing multi part records with sets and volumes, we currently show a link to "Show volumes" on the set record. The link is always shown on a set record, even if there are no linked volumes. Bug 15851 solves the same issue for analytics. volumes would be a great next step. At the moment Show volumes is only shown on monographs, but we could add the feature for serial records as well. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Bug 26314 depends on bug 15851, which changed state. Bug 15851 Summary: Only display "Analytics: Show analytics" when records have linked analytics https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123615&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Built with inspiration based on bug 11175 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 [Bug 28830] Add CNI (Control Number Identifier) search index -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Nice. But like for analyticals, please add eval() in get_marc_volumes() in case search fails, see Bug 28682 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good call, I wasn't aware of that bug. I'll add a follow-up layer today. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123615|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124367&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Regarding the eval Fridolin mentions.. I'm tempted to switch the get_volumes_query routine to using build_query_compat internally instead which should yield us a more reliably constructed search query string with special characters removed. That way, with bug 28316 work progressing we will get the advantages it brings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 [Bug 28316] Fix ES crashes related to various punctuation characters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124367|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124380&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124381&action=edit Bug 26314: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Bug 26314 depends on bug 28830, which changed state. Bug 28830 Summary: Add CNI (Control Number Identifier) search index (MARC21) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11175 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124380|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126448&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124381|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126449&action=edit Bug 26314: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126450&action=edit Bug 26314: (follow-up) Make title search explicit This patch updates the get_volumes_query search returned when UseControlNumber is disabled such that it matches the query produced by XSLT sheets by replacing the ->title accessor with the more specific ->subfield('245', "a") accessor to just take subfield `a` into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I think we should not load this logic into XSLT module. It does not belong there imo. Just pass the xslt_variable show_volumes_link in the detail scripts using it (probably opac-detail, catalogue detail, shelves?) If this would result in code duplication, add a biblio method for it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Understood. Let's get 11175 over the finish line before we continue on this one however. I think we should also pass the query string itself as an XSLT param and drop the logic in the XSLT.. that way we can guarantee the link search and the search used in the controllers are always in sync. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126448|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126952&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126449|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126953&action=edit Bug 26314: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126450|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126954&action=edit Bug 26314: (follow-up) Make title search explicit This patch updates the get_volumes_query search returned when UseControlNumber is disabled such that it matches the query produced by XSLT sheets by replacing the ->title accessor with the more specific ->subfield('245', "a") accessor to just take subfield `a` into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126955&action=edit Bug 26314: Update for changes to bug 11175 methodology This moves the show_volumes calculation back out of C4::XSLT into the controller scripts and refined the search query builder slightly based on the XSLT equivilent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I still think it might be a good idea to pass the search string from the controller instead of constructing it in two places.. keeps it dry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #18)
I still think it might be a good idea to pass the search string from the controller instead of constructing it in two places.. keeps it dry.
Not sure what you mean here. Constructing the query for components and volumes kind of the same? The shared logic could be moved? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #19)
(In reply to Martin Renvoize from comment #18)
I still think it might be a good idea to pass the search string from the controller instead of constructing it in two places.. keeps it dry.
Not sure what you mean here. Constructing the query for components and volumes kind of the same? The shared logic could be moved?
Constructing the queries for 'components parts' and 'volumes' is similar, but not the same.. it makes sense to have methods for the two distinctly. What I'm talking about is that the XSLT's also construct the same search query strings.. it would be cleaner to pass the constructed query string to the xslt as a parameter so we're re-using the code that builds the query. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #21 from Michaela Sieber <michaela.sieber@kit.edu> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried to rebase, but I get stuck at the very last patch with a 'fake ancestor'. Martin, could you have another look maybe? I think I got you some testers :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126952|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155437&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126953|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155438&action=edit Bug 26314: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126954|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155439&action=edit Bug 26314: (follow-up) Make title search explicit This patch updates the get_volumes_query search returned when UseControlNumber is disabled such that it matches the query produced by XSLT sheets by replacing the ->title accessor with the more specific ->subfield('245', "a") accessor to just take subfield `a` into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126955|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155440&action=edit Bug 26314: Update for changes to bug 11175 methodology This moves the show_volumes calculation back out of C4::XSLT into the controller scripts and refined the search query builder slightly based on the XSLT equivilent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155441&action=edit Bug 26314: (QA follow-up) Resolve new QA script failures -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased as requested.. I've made sure the QA scripts are happy and that the tests are all passing.. but I've not actually confirmed the functionality is as it was originally intended. (Honestly, it's long enough ago, I can't totally remember how it's meant to work :( ) I look forward to feedback though, so please test :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #29 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Martin Renvoize from comment #28)
Rebased as requested.. I've made sure the QA scripts are happy and that the tests are all passing.. but I've not actually confirmed the functionality is as it was originally intended. (Honestly, it's long enough ago, I can't totally remember how it's meant to work :( )
I look forward to feedback though, so please test :)
Thanks Martin! I start testing in a few minutes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155437|0 |1 is obsolete| | --- Comment #30 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 155446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155446&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155438|0 |1 is obsolete| | --- Comment #31 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 155447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155447&action=edit Bug 26314: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155439|0 |1 is obsolete| | --- Comment #32 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 155448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155448&action=edit Bug 26314: (follow-up) Make title search explicit This patch updates the get_volumes_query search returned when UseControlNumber is disabled such that it matches the query produced by XSLT sheets by replacing the ->title accessor with the more specific ->subfield('245', "a") accessor to just take subfield `a` into account. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155440|0 |1 is obsolete| | --- Comment #33 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 155449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155449&action=edit Bug 26314: Update for changes to bug 11175 methodology This moves the show_volumes calculation back out of C4::XSLT into the controller scripts and refined the search query builder slightly based on the XSLT equivilent. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155441|0 |1 is obsolete| | --- Comment #34 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 155450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155450&action=edit Bug 26314: (QA follow-up) Resolve new QA script failures Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #35 from Michaela Sieber <michaela.sieber@kit.edu> --- Works as expected :-) If you would like to have a look on my tests please check Sandbox: https://staff-b26314.sandboxes.biblibre.eu/ If you search for index-term-genre:Monografische Reihe you will find 3 series only the second has the 'Show volumes' link The first and the third don't have this link because there are no volumes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #36 from Michaela Sieber <michaela.sieber@kit.edu> --- P(In reply to Michaela Sieber from comment #35)
Works as expected :-)
If you would like to have a look on my tests please check Sandbox: https://staff-b26314.sandboxes.biblibre.eu/
I forgot to mention that System preference UseControlNumber is set to ‘Use’ "Use record control number ($w subfields) and control number (001) for linking of bibliographic records. " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome, thanks for testing Michaela 😁 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 155446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155446 Bug 26314: Only display volumes link when required Review of attachment 155446: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=26314&attachment=155446) ----------------------------------------------------------------- Note to self, do we still need to 008 and other check we have in the XSLT here after the penultimate patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Note to self, do we still need to 008 and other check we have in the XSLT here after the penultimate patch?
The POD in this patch is not completely right as it only talks about 773, we could correct that, but I am not sure if it's worth changing up things now. There are two ways to express a Set > volumes relationship: Case 1: 773 Set: 001 xxx 003 DE-627 Volume with dependent title: 773 _a volume title _w xxx Set: 001 1020782544 003 DE-627 Case 2: 8xx/449 pairs Volume with independent title: 830 0 _a Advances in analysis and geometry ; _v Volume 5 _w 1020782544 _x 2511-0438 And actually Michaela tested the second case. So we know it works with both cases, with and without the (003) prefix $w. (I verified) The problem I see is the rcn index is broad. It indexes all $w subfields from various linking fields. That's why the link includes NOT (bib-level:a OR bib-level:b) - so we can differentiate between analytical records and monographic ones. ... and that's why I thikn we better keep the checks on 008 and LDR. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155446|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155670&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155447|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155671&action=edit Bug 26314: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155448|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155672&action=edit Bug 26314: (follow-up) Make title search explicit This patch updates the get_volumes_query search returned when UseControlNumber is disabled such that it matches the query produced by XSLT sheets by replacing the ->title accessor with the more specific ->subfield('245', "a") accessor to just take subfield `a` into account. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155449|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155673&action=edit Bug 26314: Update for changes to bug 11175 methodology This moves the show_volumes calculation back out of C4::XSLT into the controller scripts and refined the search query builder slightly based on the XSLT equivilent. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155450|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155674&action=edit Bug 26314: (QA follow-up) Resolve new QA script failures Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155675&action=edit Bug 26314: (QA follow-up) Improve POD and fix links for UseControlNumber off When UseControlNumber is off, we previously did a search on the title index, but this was not actually correct. It might work when we have a dependent title and the title also appears on 245$p, but there is a better way: The title of the set record will be found in: * 773$3 for a dependent title * 800/810/811/830 for an independent title The search indices to use are host-item and title-series. As we are not only looking for 773, POD was adjusted to reflect that. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155670|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155676&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155671|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155677&action=edit Bug 26314: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155672|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155678&action=edit Bug 26314: (follow-up) Make title search explicit This patch updates the get_volumes_query search returned when UseControlNumber is disabled such that it matches the query produced by XSLT sheets by replacing the ->title accessor with the more specific ->subfield('245', "a") accessor to just take subfield `a` into account. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155673|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155679&action=edit Bug 26314: Update for changes to bug 11175 methodology This moves the show_volumes calculation back out of C4::XSLT into the controller scripts and refined the search query builder slightly based on the XSLT equivilent. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155674|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155680&action=edit Bug 26314: (QA follow-up) Resolve new QA script failures Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155675|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155681&action=edit Bug 26314: (QA follow-up) Improve POD and fix links for UseControlNumber off When UseControlNumber is off, we previously did a search on the title index, but this was not actually correct. It might work when we have a dependent title and the title also appears on 245$p, but there is a better way: The title of the set record will be found in: * 773$3 for a dependent title * 800/810/811/830 for an independent title The search indices to use are host-item and title-series. As we are not only looking for 773, POD was adjusted to reflect that. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just a note on the 008: Yes, it still makes sense: For continuing resources: 008, Pos. 21 = m - Monographic series As the 008 fields change depending on LDR 6 and 7, there are additional requirements: LDR, pos. 6 = Language material AND LDR, pos. 7 = b - Serial component part i - integrating resource s - serial We check LDR pos. 6 but omit pos=7. This was there previously and I think it does no harm for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #53 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Comment on attachment 155678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155678 Bug 26314: (follow-up) Make title search explicit
- my $cleaned_title = $marc->title; + my $cleaned_title = $marc->subfield('245', "a");
Is this correct if we think of UNIMARC? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #53)
Comment on attachment 155678 [details] [review] Bug 26314: (follow-up) Make title search explicit
- my $cleaned_title = $marc->title; + my $cleaned_title = $marc->subfield('245', "a");
Is this correct if we think of UNIMARC?
No, it wouldn't be, but this is currently marked as a MARC21 only feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #55 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35099 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35099 [Bug 35099] Cannot load records with invalid marcxml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #56 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35330 [Bug 35330] Split rcn index to allow for more specific searches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development changes release notes| |how the _Show volumes_ link | |is displayed in both OPAC | |and staff interface. | | | |The | |main change is: | |* It is | |only displayed if it would | |actually have results | |(right now it always shows, | |and the link can point to | |empty results) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15851 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This development changes |This development changes release notes|how the _Show volumes_ link |how the _Show volumes_ link |is displayed in both OPAC |is displayed in both OPAC |and staff interface. |and staff interface. | | |The |The |main change is: |main change is that the |* It is |link will only be displayed |only displayed if it would |when it will have results. |actually have results |Currently the link will |(right now it always shows, |always display, sometimes |and the link can point to |leading to no results. |empty results) | Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #57 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi, we are 4-5 people in the docs team looking at this and none of us understand how to get the "Show volumes" link to appear. Can someone either specify exactly what is needed in the record for this to appear or provide example records where this works? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #58 from Heather <heather_hernandez@nps.gov> --- Hi! I'm working on it--I'll try to create records where this works & attach them to this bug! --h2 "Real Cataloger!":) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #59 from Michaela Sieber <michaela.sieber@kit.edu> --- Hey Heather, maybe this helps: https://katalog.bibliothek.kit.edu/cgi-bin/koha/opac-search.pl?idx=&q=1748615742&weight_search=1 Series record ( 001 = 1748615742 ) : https://katalog.bibliothek.kit.edu/cgi-bin/koha/opac-detail.pl?biblionumber=... Volume record with Link to Series in MARC field 830 $w 830 _a Computational and applied mathematics ; _v Volume 1 _9 1 _w 1748615742. https://katalog.bibliothek.kit.edu/cgi-bin/koha/opac-MARCdetail.pl?biblionum... Regards Michaela -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #60 from Heather <heather_hernandez@nps.gov> --- (In reply to Michaela Sieber from comment #59)
Hey Heather,
maybe this helps:
https://katalog.bibliothek.kit.edu/cgi-bin/koha/opac-search.
Hi, Michaela! Thank you! The MARC21 tagging looks correct. I have no idea why this search: rcn:1748615742 Retrieves the monographic title: Eigenwertaufgaben in Hilbertschen Räumen With an 001 of: 1751061221 I exported the "Computational..." bib & examined it, and it appears to have "encoding issues...?" --h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #61 from Heather <heather_hernandez@nps.gov> --- Created attachment 162163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162163&action=edit Serial record for Mythlore imported & exported from https://demo-admin.catalyst-koha.com.au/ This is a MARC21 serial record that I imported from the Library of Congress for the title Mythlore, into https://demo-admin.catalyst-koha.com.au/ and then created an analytic record for a pretend article in it that I'll also attach. --h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #62 from Heather <heather_hernandez@nps.gov> --- Created attachment 162164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162164&action=edit A pretend analytic MARC21 record with Mythlore as its host record In the catalog https://demo-admin.catalyst-koha.com.au/ this analytic record for a pretend article in the serial Mythlore correctly links to Mythlore as its host record via data in its 773 field. --h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at the last comments, I wonder if there is a confusion about volumes vs. analytics. While a volume can be linked to a set record using 773, it's a little bit different. Maybe these notes will help a little: Case 1: Volume with dependent title (773) ##Set: LDR, pos. 19 = a - Set 001 xxx 003 OrgCode ##Volume: LDR, pos. 7 = m - Monograph/Item LDR, pos. 19 = c - Part with dependent title 773 _a volume title _w xxx Case 2: Volume with independent title (490/8xx) ##Set: LDR, pos. 19 = a - Set 001 yyy 003 OrgCode ##Volume: LDR, pos. 7 = m - Monograph/Item LDR, pos. 19 = b - Part with independent title 490 1 _ _a Volume title _v Vol 5 830 0 _a Volume title _v Vol 5 _w yyy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #64 from Heather <heather_hernandez@nps.gov> --- Thank you, Katrin! Yes--I was confused, and understand much better now--thank you! I think one reason is that OCLC libraries (like ours) don't have LDR position 19 accessible or displayed (maybe not even used) in their records at all--the Connexion Client software doesn't seem to allow for display or coding of this field. I know it is common for academic libraries to have a bib record on which they order & receive the volumes of a monographic series, and then catalog the volumes of the series on their own bibs, but the relationships in the bib records would be expressed with 7XX linking entry fields. The serial record used for acquisitions is sometimes even suppressed from public display. In the US, typically a record with 490/8XX fields will not have its 8XX field linking to another bib but to an authority record for the series. According to CONSER (Library of Congress) the 830 is an authorized access point (i.e., that must be authority controlled) so points to an authority record, not a bib record. So I'm probably not the best person to try to understand, explain, and help craft documentation for this feature--it sounds like it's more for a non-US cataloging workflow where a volume in a monographic series would have an 8XX pointing to a bib record (rather than carrying a 7XX linking entry field pointing to a bib record). I don't have access to a cataloging system that can show/verify the LDR position 19, so I can't verify that MARC21 coding is correct for this feature to work. I wish I could be more help! --h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #65 from Mathieu Saby <mathsabypro@gmail.com> --- Would it be possible to port this feature to unimarc please ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Mathieu Saby from comment #65)
Would it be possible to port this feature to unimarc please ?
Not easily as we don't know about the how multi-part records work in UNIMARC, indexing and XSLT might also need to be adjusted. A first step would be to file a new bug for UNIMARC linking it to this one and to start gathering the necessary information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #67 from Mathieu Saby <mathsabypro@gmail.com> --- Thank you, I will do that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/990 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |Esther Melander contact| | --- Comment #68 from Esther Melander <esther.melander@bywatersolutions.com> --- This feature is now in the manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #69 from Heather <flyingendpaper@gmail.com> --- ::standing ovation!!!:: -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org