[Bug 9603] New: Fix layout of Patron Card Creator Layout screen for display in IE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Bug ID: 9603 Summary: Fix layout of Patron Card Creator Layout screen for display in IE Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parents of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 15287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15287&action=edit Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE This patch removes empty and extraneous fieldset and li elements. It also adds ol elements to all of the nested li elements, which were creating layout problems in IE, especially when they were interwoven with div elements. IE had problems opening and closing tags, which created some major chaos. This patch also adds stylistic spacing/nesting to the HTML, so that it is easier to visually separate elements when debugging. 99.9% of the mods in this patch are actually just whitespace alterations. --- Test Plan: Before applying the patch: 1) Open Koha using any version of Internet Explorer 2) Go to the Patron Card Creator in the Tools module 3) Go to Manage Layouts 4) Add or Edit a layout 5) Note that all the elements on the page are presented in haphazard fashion with the navbar pushed to the bottom of the page. Apply the patch. 6) Refresh the page 7) Note that the elements are now laid out on the page in the same way that they would appear in a modern browser like Firefox or Chrome (look at the same page in one of those browsers to confirm). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15287|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15305&action=edit [SIGNED-OFF] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). This patch removes empty and extraneous fieldset and li elements. It also adds ol elements to all of the nested li elements, which were creating layout problems in IE, especially when they were interwoven with div elements. IE had problems opening and closing tags, which created some major chaos. This patch also adds stylistic spacing/nesting to the HTML, so that it is easier to visually separate elements when debugging. 99.9% of the mods in this patch are actually just whitespace alterations. Test Plan: Before applying the patch: 1) Open Koha using any version of Internet Explorer 2) Go to the Patron Card Creator in the Tools module 3) Go to Manage Layouts 4) Add or Edit a layout 5) Note that all the elements on the page are presented in haphazard fashion with the navbar pushed to the bottom of the page. Apply the patch. 6) Refresh the page 7) Note that the elements are now laid out on the page in the same way that they would appear in a modern browser like Firefox or Chrome (look at the same page in one of those browsers to confirm). Signed-off-by: Owen Leonard <oleonard@myacpl.org> I don't like all the whitespace changes in this patch. Making whitespace changes as well as code/markup changes is generally speaking a violation of coding guidelines. However, this is not a frequently-modified template and a diff which ignores whitespace changes shows that the real changes are minor and effective. I'm signing off and correcting the commit message to include a description of the fix and the test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #2)
I don't like all the whitespace changes in this patch. Making whitespace changes as well as code/markup changes is generally speaking a violation of coding guidelines. However, this is not a frequently-modified template and a diff which ignores whitespace changes shows that the real changes are minor and effective.
I'm signing off and correcting the commit message to include a description of the fix and the test plan.
Do not like these whitespace changes too. Could the author resolve this please and make life easier for QA? Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to M. de Rooy from comment #3)
(In reply to comment #2)
I don't like all the whitespace changes in this patch. Making whitespace changes as well as code/markup changes is generally speaking a violation of coding guidelines. However, this is not a frequently-modified template and a diff which ignores whitespace changes shows that the real changes are minor and effective.
I'm signing off and correcting the commit message to include a description of the fix and the test plan.
Do not like these whitespace changes too. Could the author resolve this please and make life easier for QA? Thanks!
If you use the -w flag to not show whitespace changes, you should be all right. However, I'm working on this patch again locally today, so I'll look at uploading a new version with code changes in one patch and whitespace changes in the other. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15305|0 |1 is obsolete| | --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 20519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20519&action=edit Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parts of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). --- This patch removes empty and extraneous fieldset and li elements. It also adds ol elements to all of the nested li elements, which were creating layout problems in IE, especially when they were interwoven with div elements. IE had problems opening and closing tags, which created some major chaos. --- Test Plan: Before applying the patch: 1) Open Koha using any version of Internet Explorer 2) Go to the Patron Card Creator in the Tools module 3) Go to Manage Layouts 4) Add or Edit a layout 5) Note that all the elements on the page are presented in haphazard fashion with the navbar pushed to the bottom of the page. Apply the patch. 6) Refresh the page 7) Note that the elements are now laid out on the page in the same way that they would appear in a modern browser like Firefox or Chrome (look at the same page in one of those browsers to confirm). (N.B. The exception is IE7. While the layout has been improved, it is now displayed linearly (i.e. without the YUI grid system). I've opened up Bug 10772 to start discussing this problem.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Actually, I'm not sure that it's necessary to add a patch for the whitespace. I will if folks think it's a good idea, but this is the essence of the patch. P.S. It looks like I forgot to include Owen's sign off in this latest patch. Could QA folks add that back in if necessary? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20519|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20627&action=edit [SIGNED-OFF] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parts of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20627|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20672&action=edit [PASSED QA] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parts of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I didn't test this in IE, but changes are fixing general problems with HTML validity. Checking the page with the W3C validator: Before: 27 Errors, 7 warning(s) After: 6 Errors, 7 warning(s) All tests and QA script pass, page looks alright. Would be nice to see the remaining problems fixed in a follow-up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master -- thanks, David! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org