[Bug 10574] New: Remove the message about upgrading to 3.4
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Bug ID: 10574 Summary: Remove the message about upgrading to 3.4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: robin@catalyst.net.nz CC: robin@catalyst.net.nz When doing a fresh installation, a warning note about a command that needs to be run when going up from 3.2 is displayed. This is useless in most cases. The script that manages this should be changed to only display the note if you are actually coming from 3.2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |robin@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 19569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19569&action=edit Empty package that claims to be koha 3.2.2 for testing upgrades -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 19570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19570&action=edit Bug 10574 - mute the "upgrading from 3.2" message New installs get the message about running a script if upgrading from 3.2. They shouldn't. This silences this message in all cases except when you actually are upgrading from 3.2. Test plan: There are three scenarios to test: 1) A fresh install should not cause the prompt. 2) An upgrade with or without the debconf entry set should not cause the prompt. 3) An upgrade from a 3.2 release to this should cause the prompt. To remove the debconf entry that says the prompt has been seen: echo 'unregister koha-common/3.2-3.4-upgrade-notice' | sudo debconf-communicate koha-common This should be run before every test to make debconf forget that it's shown the prompt. To get its current state: sudo debconf-show koha-common To test against the 3.2 version, an empty package that claims to be Koha 3.2.2 is attached to the bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- This test plan makes me happy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19570|0 |1 is obsolete| | --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 19968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19968&action=edit Bug 10574 - mute the "upgrading from 3.2" message New installs get the message about running a script if upgrading from 3.2. They shouldn't. This silences this message in all cases except when you actually are upgrading from 3.2. Test plan: There are three scenarios to test: 1) A fresh install should not cause the prompt. 2) An upgrade with or without the debconf entry set should not cause the prompt. 3) An upgrade from a 3.2 release to this should cause the prompt. To remove the debconf entry that says the prompt has been seen: echo 'unregister koha-common/3.2-3.4-upgrade-notice' | sudo debconf-communicate koha-common This should be run before every test to make debconf forget that it's shown the prompt. To get its current state: sudo debconf-show koha-common To test against the 3.2 version, an empty package that claims to be Koha 3.2.2 is attached to the bug. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net Severity|enhancement |minor --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Galen approved my change from enhancement to bug for this one. Patch works nicely for me. Thanks for fixing this, it is very confusing to people installing Koha for the first time. I hope to see it in 3.12 and 3.10 too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19968|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20823&action=edit Bug 10574 - mute the "upgrading from 3.2" message New installs get the message about running a script if upgrading from 3.2. They shouldn't. This silences this message in all cases except when you actually are upgrading from 3.2. Test plan: There are three scenarios to test: 1) A fresh install should not cause the prompt. 2) An upgrade with or without the debconf entry set should not cause the prompt. 3) An upgrade from a 3.2 release to this should cause the prompt. To remove the debconf entry that says the prompt has been seen: echo 'unregister koha-common/3.2-3.4-upgrade-notice' | sudo debconf-communicate koha-common This should be run before every test to make debconf forget that it's shown the prompt. To get its current state: sudo debconf-show koha-common To test against the 3.2 version, an empty package that claims to be Koha 3.2.2 is attached to the bug. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Robin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org