[Bug 40082] New: PatronDuplicateMatchingAddFields isn't respected in the OPAC or the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Bug ID: 40082 Summary: PatronDuplicateMatchingAddFields isn't respected in the OPAC or the API Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com There is a syspref for checking new patrons for duplicates that is only implemented in the staff interface - it should also be respected when adding a patron via the API or the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182990&action=edit Bug 40082: Move the duplicate matching logic to the Koha::Patrons class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182991&action=edit Bug 40082: Use the new duplicate checking method in the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182992&action=edit Bug 40082: Use the new duplicate checking method in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182993&action=edit Bug 40082: Add unit tests Test plan: 1) Choose an existing patron and note their first and second names as well as their date of birth 2) In the interface, create a new patron and enter all of those details to be the same as your patron from step 1 3) Submit the form, you will get a warning saying that there is a duplicate 4) In the OPAC, self register a new patron using the same details again 5) The form should submit with no error or warning 6) Apply patch, yarn api:bundle and restart_all 7) Repeat steps 2 - 5 8) Step 3 should still have the same behaviour 9) Step 5 should now show a warning at the top to say that there is a duplicate, please contact a member of staff 10) Find the 'PatronDuplicateMatchingAddFields' syspref and select an extra field there, ensuring that your patron from step 1 has data for that field 11) In either the interface or the OPAC, register a new patron but this time change the data of the new field you added in step 10 12) No warning should show for a duplicate patron 13) prove t/db_dependent/api/v1/patrons.t 14) prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182990|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182994&action=edit Bug 40082: Move the duplicate matching logic to the Koha::Patrons class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182991|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182995&action=edit Bug 40082: Use the new duplicate checking method in the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182992|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182996&action=edit Bug 40082: Use the new duplicate checking method in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182993|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182997&action=edit Bug 40082: Add unit tests Test plan: 1) Choose an existing patron and note their first and second names as well as their date of birth 2) In the interface, create a new patron and enter all of those details to be the same as your patron from step 1 3) Submit the form, you will get a warning saying that there is a duplicate 4) In the OPAC, self register a new patron using the same details again 5) The form should submit with no error or warning 6) Apply patch, yarn api:bundle and restart_all 7) Repeat steps 2 - 5 8) Step 3 should still have the same behaviour 9) Step 5 should now show a warning at the top to say that there is a duplicate, please contact a member of staff 10) Find the 'PatronDuplicateMatchingAddFields' syspref and select an extra field there, ensuring that your patron from step 1 has data for that field 11) In either the interface or the OPAC, register a new patron but this time change the data of the new field you added in step 10 12) No warning should show for a duplicate patron 13) prove t/db_dependent/api/v1/patrons.t 14) prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |andrew@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Matt, can you please rebase? I seem to be doing something wrong in clearing merge errors in t/db_dependent/Koha/Patrons.t, causing it to fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182994|0 |1 is obsolete| | --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 187844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187844&action=edit Bug 40082: Move the duplicate matching logic to the Koha::Patrons class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182995|0 |1 is obsolete| | --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 187845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187845&action=edit Bug 40082: Use the new duplicate checking method in the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182996|0 |1 is obsolete| | --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 187846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187846&action=edit Bug 40082: Use the new duplicate checking method in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182997|0 |1 is obsolete| | --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 187847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187847&action=edit Bug 40082: Add unit tests Test plan: 1) Choose an existing patron and note their first and second names as well as their date of birth 2) In the interface, create a new patron and enter all of those details to be the same as your patron from step 1 3) Submit the form, you will get a warning saying that there is a duplicate 4) In the OPAC, self register a new patron using the same details again 5) The form should submit with no error or warning 6) Apply patch, yarn api:bundle and restart_all 7) Repeat steps 2 - 5 8) Step 3 should still have the same behaviour 9) Step 5 should now show a warning at the top to say that there is a duplicate, please contact a member of staff 10) Find the 'PatronDuplicateMatchingAddFields' syspref and select an extra field there, ensuring that your patron from step 1 has data for that field 11) In either the interface or the OPAC, register a new patron but this time change the data of the new field you added in step 10 12) No warning should show for a duplicate patron 13) prove t/db_dependent/api/v1/patrons.t 14) prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187847|0 |1 is obsolete| | --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189386&action=edit Bug 40082: Add unit tests Test plan: 1) Choose an existing patron and note their first and second names as well as their date of birth 2) In the interface, create a new patron and enter all of those details to be the same as your patron from step 1 3) Submit the form, you will get a warning saying that there is a duplicate 4) In the OPAC, self register a new patron using the same details again 5) The form should submit with no error or warning 6) Apply patch, yarn api:bundle and restart_all 7) Repeat steps 2 - 5 8) Step 3 should still have the same behaviour 9) Step 5 should now show a warning at the top to say that there is a duplicate, please contact a member of staff 10) Find the 'PatronDuplicateMatchingAddFields' syspref and select an extra field there, ensuring that your patron from step 1 has data for that field 11) In either the interface or the OPAC, register a new patron but this time change the data of the new field you added in step 10 12) No warning should show for a duplicate patron 13) prove t/db_dependent/api/v1/patrons.t 14) prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187844|0 |1 is obsolete| | --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189389&action=edit Bug 40082: Move the duplicate matching logic to the Koha::Patrons class Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187845|0 |1 is obsolete| | --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189390&action=edit Bug 40082: Use the new duplicate checking method in the API Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187846|0 |1 is obsolete| | --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189391&action=edit Bug 40082: Use the new duplicate checking method in the OPAC Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189386|0 |1 is obsolete| | --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189392&action=edit Bug 40082: Add unit tests Test plan: 1) Choose an existing patron and note their first and second names as well as their date of birth 2) In the interface, create a new patron and enter all of those details to be the same as your patron from step 1 3) Submit the form, you will get a warning saying that there is a duplicate 4) In the OPAC, self register a new patron using the same details again 5) The form should submit with no error or warning 6) Apply patch, yarn api:bundle and restart_all 7) Repeat steps 2 - 5 8) Step 3 should still have the same behaviour 9) Step 5 should now show a warning at the top to say that there is a duplicate, please contact a member of staff 10) Find the 'PatronDuplicateMatchingAddFields' syspref and select an extra field there, ensuring that your patron from step 1 has data for that field 11) In either the interface or the OPAC, register a new patron but this time change the data of the new field you added in step 10 12) No warning should show for a duplicate patron 13) prove t/db_dependent/api/v1/patrons.t 14) prove t/db_dependent/Koha/Patrons.t Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189389|0 |1 is obsolete| | --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189416&action=edit Bug 40082: Move the duplicate matching logic to the Koha::Patrons class Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Pamela Bird <pbird@cityofchesapeake.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189390|0 |1 is obsolete| | --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189417&action=edit Bug 40082: Use the new duplicate checking method in the API Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Pamela Bird <pbird@cityofchesapeake.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189391|0 |1 is obsolete| | --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189418&action=edit Bug 40082: Use the new duplicate checking method in the OPAC Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Pamela Bird <pbird@cityofchesapeake.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189392|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189419&action=edit Bug 40082: Add unit tests Test plan: 1) Choose an existing patron and note their first and second names as well as their date of birth 2) In the interface, create a new patron and enter all of those details to be the same as your patron from step 1 3) Submit the form, you will get a warning saying that there is a duplicate 4) In the OPAC, self register a new patron using the same details again 5) The form should submit with no error or warning 6) Apply patch, yarn api:bundle and restart_all 7) Repeat steps 2 - 5 8) Step 3 should still have the same behaviour 9) Step 5 should now show a warning at the top to say that there is a duplicate, please contact a member of staff 10) Find the 'PatronDuplicateMatchingAddFields' syspref and select an extra field there, ensuring that your patron from step 1 has data for that field 11) In either the interface or the OPAC, register a new patron but this time change the data of the new field you added in step 10 12) No warning should show for a duplicate patron 13) prove t/db_dependent/api/v1/patrons.t 14) prove t/db_dependent/Koha/Patrons.t Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Pamela Bird <pbird@cityofchesapeake.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Adding a user sign-off and bumping my own SO up to QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if we should make this text messsage more neutral to not give away that a user with these credentials already exists. It might give away information we don't want to give away. The selfreg form could be used to look-up users. + [% IF duplicate_found %] + <div class="alert alert-error"> + <span>An existing account matching these details has been found, please contact a member of staff</span> + </div> + [% END %] + -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #26 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40082 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42018 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org