[Bug 19329] New: The automatic slip printing does not work when IntranetSlipPrinterJS defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Bug ID: 19329 Summary: The automatic slip printing does not work when IntranetSlipPrinterJS defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17014 Assignee|oleonard@myacpl.org |josef.moravec@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014 [Bug 17014] Remove more event attributes from patron templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 67172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67172&action=edit Bug 19329: Fix slip printing when IntranetSlipPrinterJS defined Test plan: 1) Set IntranetSlipPrinterJS according to documentation (= define function printThenClose) 2) Go to circulation and try to print some slip => without patch the printThenClose function is not executed => with patch it is executed as it should -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- The manual refers to the wiki, which includes this instruction: "Important: The script must implement the function $( window ).load(function() because it replaces the original function)." The example on that wiki page includes a try-catch example which includes "window.print()" and "window.close()." Isn't this patch going to create conflicts for libraries with existing IntranetSlipPrinterJS setups? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #2)
The manual refers to the wiki, which includes this instruction:
"Important: The script must implement the function $( window ).load(function() because it replaces the original function)."
The example on that wiki page includes a try-catch example which includes "window.print()" and "window.close()."
Isn't this patch going to create conflicts for libraries with existing IntranetSlipPrinterJS setups?
In that case, yes it would be conflict. Then we need to document it better in UI, because the text by the system preference '' says: 'Use the following JavaScript for printing slips. Define at least function printThenClose().' Which is what does not work. I will rework the patch to just change this sentence. Thanks Owen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67172|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The automatic slip printing |IntranetSlipPrinterJS label |does not work when |is obsoleted |IntranetSlipPrinterJS | |defined | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 67197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67197&action=edit Bug 19329: Update IntranetSlipPrinterJS system preference description. Test plan: 0) Apply the patch 1) Go to administration -> system preferences -> staff client 2) Read the description by IntranetSlipPrinterJS and confirm it's right -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67197|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 67199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67199&action=edit Bug 19329: Update IntranetSlipPrinterJS system preference description. Test plan: 0) Apply the patch 1) Go to administration -> system preferences -> staff client 2) Read the description by IntranetSlipPrinterJS and confirm it's right Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67199|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 67435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67435&action=edit Bug 19329: Update IntranetSlipPrinterJS system preference description. Test plan: 0) Apply the patch 1) Go to administration -> system preferences -> staff client 2) Read the description by IntranetSlipPrinterJS and confirm it's right Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depends on bug 17014 which is not in 16.11.x, skipping. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org