[Bug 19135] New: AllowHoldsOnPatronsPossessions is not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Bug ID: 19135 Summary: AllowHoldsOnPatronsPossessions is not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66148&action=edit Bug 19135 - AllowHoldsOnPatronsPossessions not working Test Plan: 1) Set AllowHoldsOnPatronsPossessions to "Don't" 2) Check out an item to a patron 3) Place a hold on that item for the same patron 4) Note you are allowed to with no alert 5) Delete the hold 6) Apply this patch 7) Place a hold on that item for the same patron 8) Note you recieve an alert now Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 66149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66149&action=edit [SIGNED OFF] Bug 19135 - AllowHoldsOnPatronsPossessions not working Test Plan: 1) Set AllowHoldsOnPatronsPossessions to "Don't" 2) Check out an item to a patron 3) Place a hold on that item for the same patron 4) Note you are allowed to with no alert 5) Delete the hold 6) Apply this patch 7) Place a hold on that item for the same patron 8) Note you recieve an alert now Works as expected. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Cheryl <clackman@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please update the commit message with something more meaningful (what the patch does?) Why do not you just remove the superfluous line? I will make the diff easier to read and backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66148|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upping severity, it impacts last 2 stable releases (17.05.x and 16.11.x). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, commit message includes a test plan, what did you mean? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #5)
Hi Jonathan, commit message includes a test plan, what did you mean?
"AllowHoldsOnPatronsPossessions not working" is not a correct and explicit commit title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- My remarks should not block QA, I can edit the commit message later if the author of the patch does not do it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66149|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 67684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67684&action=edit Bug 19135 - AllowHoldsOnPatronsPossessions not working Test Plan: 1) Set AllowHoldsOnPatronsPossessions to "Don't" 2) Check out an item to a patron 3) Place a hold on that item for the same patron 4) Note you are allowed to with no alert 5) Delete the hold 6) Apply this patch 7) Place a hold on that item for the same patron 8) Note you recieve an alert now Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm two signoffs on my name. Where did this patch come from? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bug caused by commit bc39f0392bbebaad4c083f81308f652a325be042 Bug 14695 - Add ability to place multiple item holds on a given record per patron (In reply to Jonathan Druart from comment #3)
Why do not you just remove the superfluous line? I will make the diff easier to read and backport.
I am going to amend the patch to only remove the problematic line in order to make the change easier to read. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67684|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67718&action=edit Bug 19135: Restore AllowHoldsOnPatronsPossessions behaviour Bug caused by commit bc39f0392bbebaad4c083f81308f652a325be042 Bug 14695 - Add ability to place multiple item holds on a given record per patron Test Plan: 1) Set AllowHoldsOnPatronsPossessions to "Don't" 2) Check out an item to a patron 3) Place a hold on that item for the same patron 4) Note you are allowed to with no alert 5) Delete the hold 6) Apply this patch 7) Place a hold on that item for the same patron 8) Note you recieve an alert now Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdeca@smfpl.org --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 13374 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13374 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.06. Lines are impacted by Bug 17829 but rebase was easy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org