[Bug 42299] New: OPAC detail page: star ratings has no associated label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 Bug ID: 42299 Summary: OPAC detail page: star ratings has no associated label Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org To recreate: 1. Set OpacStarRatings so it shows on the OPAC detail page 2. Notice star ratings has no associated label element -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 197015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197015&action=edit Bug 42299: Add accessible label to star rating select in OPAC To test: 1. Set OpacStarRatings so it shows on the OPAC detail page 2. Notice star ratings has no associated label element 3. Apply the patch and refresh the OPAC detail page you were viewing. 4. Notice that the star ratings now have an accessible label. 5. Sign off and have a great day. :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 197112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197112&action=edit Bug 42299: Add accessible label to star rating select in OPAC To test: 1. Set OpacStarRatings so it shows on the OPAC detail page 2. Notice star ratings has no associated label element 3. Apply the patch and refresh the OPAC detail page you were viewing. 4. Notice that the star ratings now have an accessible label. 5. Sign off and have a great day. :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an accessibility release notes| |issue for star ratings on | |the OPAC record details | |page - it adds a label for | |screen reader patrons. CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Before the patch, inspecting the HTML source: ... <div class="br-wrapper br-theme-fontawesome-stars"> <select id="star_rating" class="star_rating" name="rating" data-biblionumber="262" data-context="rating-262" autocomplete="off" style="display: none;"> ... 2. After the patch: ... added--> <label for="star_rating" class="sr-only">Rate this title from 1 to 5 stars</label> <div class="br-wrapper br-theme-fontawesome-stars"> <select id="star_rating" class="star_rating" name="rating" data-biblionumber="262" data-context="rating-262" autocomplete="off" style="display: none;"> ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197112|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200197&action=edit Bug 42299: Add accessible label to star rating select in OPAC To test: 1. Set OpacStarRatings so it shows on the OPAC detail page 2. Notice star ratings has no associated label element 3. Apply the patch and refresh the OPAC detail page you were viewing. 4. Notice that the star ratings now have an accessible label. 5. Sign off and have a great day. :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42299 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org