[Bug 42245] New: Patron search for guarantors is preselecting borrower sort values from the borrower record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 Bug ID: 42245 Summary: Patron search for guarantors is preselecting borrower sort values from the borrower record Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com av-build-dropbox.inc takes a 'default' param When building the patron we are setting this to the value of sort1, then sort2 This seems to remain cached, and when we build the guarantor search the sort2 value is used as the default To recreate: 1 - Define 2 values for 'BSort1' in Administration -> Authorised values 2 - Define 2 values for 'BSort2' in Administration -> Authorised values 3 - Find a borrower who is eligible to have a guarantor 4 - Edit patron and assign values to sort 1 and 2 for this borrower and save 5 - Edit patron again and click 'Add guarantor' 6 - Note that sort 2 is populated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 196630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196630&action=edit Bug 42245: Prevent preselecting sort values for guarantor search av-build-dropbox.inc takes a 'default' param When building the patron we are setting this to the value of sort1, then sort2 This seems to remain cached, and when we build the guarantor search the sort2 value is used as the default This patch ensures we pass a blank default to the modal To recreate: 1 - Define 2 values for 'BSort1' in Administration -> Authorised values 2 - Define 2 values for 'BSort2' in Administration -> Authorised values 3 - Find a borrower who is eligible to have a guarantor 4 - Edit patron and assign values to sort 1 and 2 for this borrower and save 5 - Edit patron again and click 'Add guarantor' 6 - Note that sort 2 is populated 7 - Apply patch 8 - Reload borrower 9 - Confirm sort1 and 2 are empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 Ashley Hernandez <ahernandez@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahernandez@ckls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 197136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197136&action=edit Bug 42245: Prevent preselecting sort values for guarantor search av-build-dropbox.inc takes a 'default' param When building the patron we are setting this to the value of sort1, then sort2 This seems to remain cached, and when we build the guarantor search the sort2 value is used as the default This patch ensures we pass a blank default to the modal To recreate: 1 - Define 2 values for 'BSort1' in Administration -> Authorised values 2 - Define 2 values for 'BSort2' in Administration -> Authorised values 3 - Find a borrower who is eligible to have a guarantor 4 - Edit patron and assign values to sort 1 and 2 for this borrower and save 5 - Edit patron again and click 'Add guarantor' 6 - Note that sort 2 is populated 7 - Apply patch 8 - Reload borrower 9 - Confirm sort1 and 2 are empty Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the "Add release notes| |guarantor" pop-up window | |when adding a guarantor for | |a patron. | | | |The form was populating the | |"Sort 2" field with the | |value from the patron you | |are adding the guarantor to | |(if they had values stored | |for the Sort 1 and Sort 2 | |fields in the library | |management section). --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For the patron, I used Lisa Charles (borrower number = 37) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197136|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200200&action=edit Bug 42245: Prevent preselecting sort values for guarantor search av-build-dropbox.inc takes a 'default' param When building the patron we are setting this to the value of sort1, then sort2 This seems to remain cached, and when we build the guarantor search the sort2 value is used as the default This patch ensures we pass a blank default to the modal To recreate: 1 - Define 2 values for 'BSort1' in Administration -> Authorised values 2 - Define 2 values for 'BSort2' in Administration -> Authorised values 3 - Find a borrower who is eligible to have a guarantor 4 - Edit patron and assign values to sort 1 and 2 for this borrower and save 5 - Edit patron again and click 'Add guarantor' 6 - Note that sort 2 is populated 7 - Apply patch 8 - Reload borrower 9 - Confirm sort1 and 2 are empty Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42245 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org