[Bug 28470] New: Typo: Are you sure you with to chart this report?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Bug ID: 28470 Summary: Typo: Are you sure you with to chart this report? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Typo: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:1392 Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |23626 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125887&action=edit Bug 28470: Typo: Are you sure you with to chart this report? This patch corrects the text of a warning on the report results page, from this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report?") ...to this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you want to chart this report?") To test, apply the patch and go to Reports -> Use saved. - Run a report which, unlimited, will return more than 1000 rows. - Click the "Fetch all data for chart" button. - You should be asked for confirmation. Check that the text is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125887|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 125952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125952&action=edit Bug 28470: Typo: Are you sure you with to chart this report? This patch corrects the text of a warning on the report results page, from this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report?") ...to this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you want to chart this report?") To test, apply the patch and go to Reports -> Use saved. - Run a report which, unlimited, will return more than 1000 rows. - Click the "Fetch all data for chart" button. - You should be asked for confirmation. Check that the text is correct. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125952|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126022&action=edit Bug 28470: Typo: Are you sure you with to chart this report? This patch corrects the text of a warning on the report results page, from this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report?") ...to this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you want to chart this report?") To test, apply the patch and go to Reports -> Use saved. - Run a report which, unlimited, will return more than 1000 rows. - Click the "Fetch all data for chart" button. - You should be asked for confirmation. Check that the text is correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org