[Bug 29352] New: Runtime parameter labels should not be said to be optional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Bug ID: 29352 Summary: Runtime parameter labels should not be said to be optional Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Reports Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 27644 If you use the "Insert runtime parameter" button when editing an SQL report the modal window for defining a label says that the label is optional and will allow no label to be selected. This is wrong. If there is no label the parameter will be treated as a generic text input. The interface should enforce the field as required. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27644 [Bug 27644] Add button to SQL report editor for inserting runtime parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 [Bug 29351] Add missing cn_source parameter to reports parameter menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127061&action=edit Bug 29352: Runtime parameter labels should not be said to be optional This patch alters the form shown when using the "Insert runtime parameter" button in SQL reports. It makes the label field required and removes "optional" from the field hint. To test, apply the patch and go to Reports -> Create from SQL. - Click the "Insert runtime parameter" button and select "Authorized value." - Clear the "parameter label" field and click "Insert parameter." - The form should display an error asking you to fill in the label field. - Test that the category field is also required. - Close the modal and select a different runtime parameter. - Test again that the label field is required. - Test that the form submits correctly when the label field is populated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127061|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127066&action=edit Bug 29352: Runtime parameter labels should not be said to be optional This patch alters the form shown when using the "Insert runtime parameter" button in SQL reports. It makes the label field required and removes "optional" from the field hint. To test, apply the patch and go to Reports -> Create from SQL. - Click the "Insert runtime parameter" button and select "Authorized value." - Clear the "parameter label" field and click "Insert parameter." - The form should display an error asking you to fill in the label field. - Test that the category field is also required. - Close the modal and select a different runtime parameter. - Test again that the label field is required. - Test that the form submits correctly when the label field is populated. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127066|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127115&action=edit Bug 29352: Runtime parameter labels should not be said to be optional This patch alters the form shown when using the "Insert runtime parameter" button in SQL reports. It makes the label field required and removes "optional" from the field hint. To test, apply the patch and go to Reports -> Create from SQL. - Click the "Insert runtime parameter" button and select "Authorized value." - Clear the "parameter label" field and click "Insert parameter." - The form should display an error asking you to fill in the label field. - Test that the category field is also required. - Close the modal and select a different runtime parameter. - Test again that the label field is required. - Test that the form submits correctly when the label field is populated. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 27644 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org