[Bug 5409] New: Call number is not show on Opac search result page.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Summary: Call number is not show on Opac search result page. Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: amit.gupta@osslabs.biz QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Call number is not shown on opac search result page while system preference OPACItemsResultsDisplay is on. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 --- Comment #1 from Amit Gupta <amit.gupta@osslabs.biz> 2010-11-15 10:54:18 UTC --- Created attachment 2754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2754 [PATCH] Bug 5409 - Fix call number not shown on opac search result page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> 2010-11-15 12:52:20 UTC --- There is a conflict in the definition of the syspref. The SQL files install it as type choice with the possible values being 'statuses' and 'itemdetails'. The description is statuses : show only the status of items in result list. itemdisplay : show full location of items (branch+location+callnumber) as in staff interface However, preferences/searching.pref thinks that it's a Boolean: - pref: OPACItemsResultsDisplay type: boolean choices: yes: Show no: "Don't show" Since there are only two choices, even in the original definition of the system preference, the (what I suspect was inadvertent) redefinition of it in searching.pref needs a corresponding database update that would do the following: * change the type of the syspref to YesNo * set the syspref value to '1' if it is 'itemdetails' and 0 if it is 'statuses', leaving it alone if it is already 1 or 0. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2010-11-15 13:26:11 UTC --- I submitted a patch for Bug 4268 which I hoped would solve the OPACItemsResultsDisplay problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2010-11-15 13:27:03 UTC ---
I submitted a patch for Bug 4268 which I hoped would solve the OPACItemsResultsDisplay problem.
I guess my solution and Amit's were the same, and both incorrect? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 --- Comment #5 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2010-12-09 15:11:01 UTC --- This bug is mentioned in: Bug 5409 - Fix call number not shown on opac search result page http://lists.koha-community.org/pipermail/koha-patches/2010-November/013009.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Meenakshi <meenakshi.r@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2754|0 |1 is obsolete| | --- Comment #6 from Meenakshi <meenakshi.r@osslabs.biz> --- Created attachment 10288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10288&action=edit Attaching Patch. Fixes Bug 5409, Set the syspref value to 1 if it is itemdetails and 0 if it is statuses, leaving it alone if it is already 1 or 0 and change the type of the syspref to YesNo. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Meenakshi <meenakshi.r@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |meenakshi.r@osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Meenakshi <meenakshi.r@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |meenakshi.r@osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Meenakshi <meenakshi.r@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10288|0 |1 is patch| | Attachment #10288|application/octet-stream |text/plain mime type| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- I think both these patches are needed, unobsoleting one -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2754|1 |0 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2754|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11049&action=edit [SIGNED-OFF] Bug 5409 - Fix call number not shown on opac search result page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10288|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11050&action=edit [SIGNED-OFF] Bug 5409 [2] Call number is not show on Opac search result page. [SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page. Fixes Bug 5409, Set the syspref value to 1 if it is itemdetails and 0 if it is statuses, leaving it alone if it is already 1 or 0 and change the type of the syspref to YesNo. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- These patches correct the problem for the "normal" view in the OPAC. It does not affect the XSLT display. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Display the location and itemcallnumber for items if the syspref OPACItemsResultsDisplay is on. Marking as Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: I think this patch is wrong because OPACItemsResultsDisplay is not updated to boolean everywhere: installer/data/mysql/sysprefs.sql still says INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('OPACItemsResultsDisplay',"statuses",'statuses : show only the status of items in result list. itemdisplay : show full lo cation of items (branch+location+callnumber) as in staff interface',"statuses|itemdetails",'Choice'); I think other places are OK. Please provite an other follow-up & switch back to passed QA, i'll push -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 --- Comment #13 from Meenakshi <meenakshi.r@osslabs.biz> --- Created attachment 12300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12300&action=edit Attaching the latest patch. attached the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Meenakshi <meenakshi.r@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11049|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12425&action=edit [SIGNED-OFF] Bug 5409 - Fix call number not shown on opac search result page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11050|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12426&action=edit [SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page. Fixes Bug 5409, Set the syspref value to 1 if it is itemdetails and 0 if it is statuses, leaving it alone if it is already 1 or 0 and change the type of the syspref to YesNo. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12300|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12427&action=edit [SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page - QA Followup Fixes Bug 5409, Modified the definition of 'OPACItemsResultsDisplay' in systempreferences and changed the code in opac-search.pl file for 'OPACItemsResultsDisplay'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | --- Comment #17 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #16)
Created attachment 12427 [details] [SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page - QA Followup
Fixes Bug 5409, Modified the definition of 'OPACItemsResultsDisplay' in systempreferences and changed the code in opac-search.pl file for 'OPACItemsResultsDisplay'.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
patch works as expected, passing QA on 3 patches... $ koha-qa.pl -c 3 testing 3 commit(s) (applied to commit 6c18204) * bff8bed Bug 5409 - Call number is not show on Opac search result page. installer/data/mysql/sysprefs.sql * 350b661 Bug 5409 - Call number is not show on Opac search result page. installer/data/mysql/updatedatabase.pl * e9be52e Bug 5409 - Fix call number not shown on opac search result page opac/opac-search.pl * installer/data/mysql/updatedatabase.pl OK * opac/opac-search.pl OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4268 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Was pushed to 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 4268 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org