[Bug 14562] New: Patron with empty card number will be only result returned by patron datatables search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Bug ID: 14562 Summary: Patron with empty card number will be only result returned by patron datatables search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: jonathan.druart@bugs.koha-community.org Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Due to the fact that the if statement wrapping the single-patron search does not check that a cardnumber was passed, svc/members/search will attempt to search for a patron with an empty cardnumber. This should normally fail, but if such a patron exists (a possibility after importing/migrating) it will always succeed and prevent normal searching. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14601 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13232 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What kind of searches did you try? I have a patron with cardnumber="", search by letter (browse by name), and different filter combinations work here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Ah, on closer inspection, this is fixed by commit 481479fe627dcbabb3ef66df0724cc3fe75b110c: "Bug 12648: Fix conflict with bug 12833", which just needs to be backported to 3.18. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41436&action=edit Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833) This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x): commit 481479fe627dcbabb3ef66df0724cc3fe75b110c Bug 12648: Fix conflict with bug 12833 Test plan: Set the cardnumber of one of the patron to an empty string Do a patron search and use filters The search will redirect to the patron detail page of the patron with the empty string -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Can't reproduce on 3.18.9. I do a search for 't', then filter the results by search type or category. One of the patrons has an empty card number. Works for me. Anything else I should try? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 --- Comment #5 from Jesse Weaver <jweaver@bywatersolutions.com> --- This error only occurs when you don't click on a first letter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41436|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 43292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43292&action=edit Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833) Works as expected This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x): commit 481479fe627dcbabb3ef66df0724cc3fe75b110c Bug 12648: Fix conflict with bug 12833 Test plan: Set the cardnumber of one of the patron to an empty string Do a patron search and use filters The search will redirect to the patron detail page of the patron with the empty string Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Patron with empty card |[3.18.x] Patron with empty |number will be only result |card number will be only |returned by patron |result returned by patron |datatables search |datatables search -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43292|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43568&action=edit [PASSED QA] Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833) This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x): commit 481479fe627dcbabb3ef66df0724cc3fe75b110c Bug 12648: Fix conflict with bug 12833 Test plan: Set the cardnumber of one of the patron to an empty string Do a patron search and use filters The search will redirect to the patron detail page of the patron with the empty string Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #8 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x will be in 3.18.12. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org