[Bug 35954] New: Add --status to koha-plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Bug ID: 35954 Summary: Add --status to koha-plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz There is already a function called is_plack_running in koha-functions.sh. https://git.koha-community.org/Koha-community/Koha/src/branch/master/debian/... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 161740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161740&action=edit Bug 35954: Add --status to koha-plack This adds a --status switch to the koha-plack command. To test on ktd: - Copy the script to /usr/sbin, so you run the modified script, and not the one installed by Koha: $ sudo cp debian/scripts/koha-plack /usr/sbin/ - Stop and start Plack for kohadev like so: $ sudo koha-plack --stop kohadev $ sudo koha-plack --start kohadev And make sure this reports the correct status, both when Plack is running and when it is not running: $ sudo koha-plack --status kohadev - Make sure --status is mentioned here: $ sudo koha-plack --help - See https://wiki.koha-community.org/wiki/Testing_man_pages for details on how to check the manual page for the command -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161740|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 161741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161741&action=edit Bug 35954: Add --status to koha-plack This adds a --status switch to the koha-plack command. To test on ktd: - Copy the script to /usr/sbin, so you run the modified script, and not the one installed by Koha: $ sudo cp debian/scripts/koha-plack /usr/sbin/ - Stop and start Plack for kohadev like so: $ sudo koha-plack --stop kohadev $ sudo koha-plack --start kohadev And make sure this reports the correct status, both when Plack is running and when it is not running: $ sudo koha-plack --status kohadev - Make sure --status is mentioned here: $ sudo koha-plack --help - See https://wiki.koha-community.org/wiki/Testing_man_pages for details on how to check the manual page for the command -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161741|0 |1 is obsolete| | --- Comment #3 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 166095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166095&action=edit Bug 35954: Add --status to koha-plack This adds a --status switch to the koha-plack command. To test on ktd: - Copy the script to /usr/sbin, so you run the modified script, and not the one installed by Koha: $ sudo cp debian/scripts/koha-plack /usr/sbin/ - Stop and start Plack for kohadev like so: $ sudo koha-plack --stop kohadev $ sudo koha-plack --start kohadev And make sure this reports the correct status, both when Plack is running and when it is not running: $ sudo koha-plack --status kohadev - Make sure --status is mentioned here: $ sudo koha-plack --help - See https://wiki.koha-community.org/wiki/Testing_man_pages for details on how to check the manual page for the command Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tadeusz@sosnierz.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We might want to fix the patch author: From: root <root@localhost> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166095|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166106&action=edit Bug 35954: Add --status to koha-plack This adds a --status switch to the koha-plack command. To test on ktd: - Copy the script to /usr/sbin, so you run the modified script, and not the one installed by Koha: $ sudo cp debian/scripts/koha-plack /usr/sbin/ - Stop and start Plack for kohadev like so: $ sudo koha-plack --stop kohadev $ sudo koha-plack --start kohadev And make sure this reports the correct status, both when Plack is running and when it is not running: $ sudo koha-plack --status kohadev - Make sure --status is mentioned here: $ sudo koha-plack --help - See https://wiki.koha-community.org/wiki/Testing_man_pages for details on how to check the manual page for the command Signed-off-by: Tadeusz Sośnierz <tadeusz@sosnierz.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice addition, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #4)
We might want to fix the patch author: From: root <root@localhost>
Ooops, thanks for spotting and fixing that! :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35954 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org