[Bug 31981] New: Need to be able to more clearly distinguish between hold warning boxes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Bug ID: 31981 Summary: Need to be able to more clearly distinguish between hold warning boxes Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 142657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142657&action=edit warning box for example two There are potentially two yellow warning boxes staff can see when checking out an item that is on hold and the two boxes are VERY difficult to distinguish between. It would be helpful to either change the wording, or change the color of one of them to help staff determine what action should be taken. For instance, place a hold on an item for Patron A, do not trigger the hold, and check the item out to Patron B. The message is: Please confirm checkout Item Toby goes bananas / (312824) has been on hold for Donna B (donnab) at Sparkly Unicorn Land since 10/25/2022 Cancel hold Yes, check out (Y) Don't check out and print slip (P) No, don't check out (N) Cancel checkout and place a hold for Jack Shepard (68) Then check the item in, confirm the hold, then check the item out to Patron B. The message is: Please confirm checkout Item Toby goes bananas / (312824) has been waiting for Donna B (donnab) at Sparkly Unicorn Land since 10/25/2022 Cancel hold Revert waiting status The first message is much more common - libraries typically see it when a patron has placed a hold on something, but another patron has taken it off the shelf to check out before staff were able to pull it for the other patron. The second message is much less common - this is when an item is on the hold pick up shelf and a patron other than who it was triggered for is trying to check it out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 --- Comment #1 from Donna <bwsdonna@gmail.com> --- Created attachment 142658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142658&action=edit warning box for example 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- These look the same because they are the same! ( #circ_needsconfirmation ) If something NEEDSCONFIRMATION Koha will then cycle through all the possible things. In your care I believe it is: 1. [% IF ( RESERVED ) %] Item has been on hold for X since... 2. [% IF ( RESERVE_WAITING ) %] Item has been waiting for... I think we could add a ID/class to each of the NEEDSCONFIRMATION reasons. This would make it much easier to customize the dialog/alert boxes based on the reason. Would that work? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 --- Comment #3 from Donna <bwsdonna@gmail.com> --- Absolutely! Anything that would make it easier for libraries to distinguish would work! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Need to be able to more |Add classes to each |clearly distinguish between |NEEDSCONFIRM message for |hold warning boxes |easier styling in | |circ/circulation.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163647&action=edit Bug 31981: Add classes to each NEEDSCONFIRM message in circ/circulation.tt This patch adds a 'needsconfirm' class and a unique class to each NEEDSCONFIRM message on circ/circulation.tt to make these easier to style individually. To test: 1. APPLY patch 2. Review the diff to see each of the NEEDSCONFIRMATION messages. 3. Add some CSS to IntranetUserCSS like this: .needsconfirm { padding: 1em; color: #fff; } .reserved { background: blue; } .debt { background: red; } .reserve_waiting { background: orange; } .rentalcharge { background: purple; } .renew_issue { background: limegreen; } 4. Place a hold on an item for Patron A, do not trigger the hold, and check the item out to Patron B. The message background is blue. 5. Then check the item in, confirm the hold, then check the item out to Patron B. The message background is orange 6. Check something out that is already checked out to that patron, message background is lime green. 7. Have too much debt and check something out to a patron, message is red. Note: There are plenty more NEEDSCONFIRMATION messages but I don't think we need to test every single one. Note: These background colors are more testing purposes only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163647|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 163653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163653&action=edit Bug 31981: Add classes to each NEEDSCONFIRM message in circ/circulation.tt This patch adds a 'needsconfirm' class and a unique class to each NEEDSCONFIRM message on circ/circulation.tt to make these easier to style individually. To test: 1. APPLY patch 2. Review the diff to see each of the NEEDSCONFIRMATION messages. 3. Add some CSS to IntranetUserCSS like this: .needsconfirm { padding: 1em; color: #fff; } .reserved { background: blue; } .debt { background: red; } .reserve_waiting { background: orange; } .rentalcharge { background: purple; } .renew_issue { background: limegreen; } 4. Place a hold on an item for Patron A, do not trigger the hold, and check the item out to Patron B. The message background is blue. 5. Then check the item in, confirm the hold, then check the item out to Patron B. The message background is orange 6. Check something out that is already checked out to that patron, message background is lime green. 7. Have too much debt and check something out to a patron, message is red. Note: There are plenty more NEEDSCONFIRMATION messages but I don't think we need to test every single one. Note: These background colors are more testing purposes only. Signed-off-by: Donna <donna@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Donna <bwsdonna@gmail.com> --- Beautiful! Works as expected, and if there are two notices, both color boxes show on the modal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Only adds CSS classes, reviewed closely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163653|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166307&action=edit Bug 31981: Add classes to each NEEDSCONFIRM message in circ/circulation.tt This patch adds a 'needsconfirm' class and a unique class to each NEEDSCONFIRM message on circ/circulation.tt to make these easier to style individually. To test: 1. APPLY patch 2. Review the diff to see each of the NEEDSCONFIRMATION messages. 3. Add some CSS to IntranetUserCSS like this: .needsconfirm { padding: 1em; color: #fff; } .reserved { background: blue; } .debt { background: red; } .reserve_waiting { background: orange; } .rentalcharge { background: purple; } .renew_issue { background: limegreen; } 4. Place a hold on an item for Patron A, do not trigger the hold, and check the item out to Patron B. The message background is blue. 5. Then check the item in, confirm the hold, then check the item out to Patron B. The message background is orange 6. Check something out that is already checked out to that patron, message background is lime green. 7. Have too much debt and check something out to a patron, message is red. Note: There are plenty more NEEDSCONFIRMATION messages but I don't think we need to test every single one. Note: These background colors are more testing purposes only. Signed-off-by: Donna <donna@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05 released in| | Status|Passed QA |Pushed to main --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, it looks like I forgot to switch to PQA and then the script didn#t update it. This is pushed already. Did you change something in the patch or just a sign-off? https://git.koha-community.org/Koha-community/Koha/commits/branch/main/searc... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05 |24.05.00 released in| | CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Very useful small enhancement, Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de --- Comment #11 from Philip Orr <philip.orr@lmscloud.de> --- Only looked at the diff while writing release notes. But: .debt_gaurantors should be .debt_guarantors, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a unique release notes| |class to each "needs | |confirmation" message shown | |in circulation. Previously | |the only selector for any | |circulation message needing | |confirmation was | |#circ_needsconfirmation, so | |CSS or jQuery targeting | |only a single specific | |message was not easy to do. | |With this patch you can | |directly target the new | |unique class selector for | |the specific message found | |behind the class element | |.needsconfirm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 --- Comment #12 from Philip Orr <philip.orr@lmscloud.de> --- For me to reference if documentation is later needed. The unique classes that were added are: .additional_materials .age_restriction .already_issued .booked_early .booked_to_another .borrower_not_same_branch .reserved .debt .debt_guarantees .debt_gaurantors .highholds .issued_to_another .item_lost .no_rule_defined .not_for_loan_forcing .patron_cant .previssue .processing .recalled .recalled2 .reserve_waiting .reserved .rentalcharge .renew_issue .too_many_checkouts .too_many_onsite_checkouts .transferred .userblocked_overdue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Philip Orr from comment #11)
Only looked at the diff while writing release notes. But: .debt_gaurantors should be .debt_guarantors, right?
Might be a little nicer. I can provide a quick follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 167167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167167&action=edit Bug 31981: (follow-up) Fix typo in class name .debt_gaurantors > .debt_guarantors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- follow-up applied on 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org