http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8664 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8664 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13059|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 13060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13060&action=edit Bug 8664 - Add floating toolbar with save button to system preferences editor This patch adds a copy of the "save" button in a toolbar at the top of the system preferences editor. The toolbar becomes fixed at the top of the page when you scroll down, exactly like the toolbar on addbiblio.pl. Because multiple save buttons might appear when the system prefs page displays search results, the toolbar does not appear in this case. To test, open the system preferences editor and change a setting. Try saving both with the button in the toolbar and the button at the top of the page. Test scrolling to confirm that the toolbar "sticks" to the top of the page when you scroll down. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3988 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8664 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Works as expected. Just one remark about indentation, I am not a big fan of this kind of indendation: + [% UNLESS ( searchfield ) %]$(document).ready(function(){ + $('#toolbar').fixFloat(); + });[% END %] It is not blocker and we don't have enough guidelines on the template files structure. So marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8664 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.