[Bug 8758] New: Code seems useless in circ/returns.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Priority: P5 - low Change sponsored?: --- Bug ID: 8758 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Code seems useless in circ/returns.pl Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart@biblibre.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12131&action=edit Bug 8758: Remove useless code in circ/returns.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Could someone confirm this code is unused ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12131|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12255&action=edit [SINGED-OFF] Bug 8758: Remove useless code in circ/returns.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before applying the patch I removed the [% IF %] from around the markup which is removed by this patch. A table of title and patron information appeared which I don't remember ever seeing before. This tells me it's really unused. After applying the patch I performed some check-ins on both checked out items and items which were on hold. All operations completed normally. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|master |rel_3_12 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * patch with a very big side effect, if we missed a case where this information is displayed. That's why I won't push it for 3.10, it fit the rule of "Feature Freeze" * koha-qa.pl OK * remove code only passed QA. Will be pushed after 3.10 release (and not pushed by me ;-) ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Version|3.12 |3.10 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org