[Bug 8596] New: Reports interface date picker doesn't force ISO formatted dates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 Priority: P5 - low Change sponsored?: --- Bug ID: 8596 Assignee: gmcharlt@gmail.com Summary: Reports interface date picker doesn't force ISO formatted dates Severity: normal Classification: Unclassified OS: All Reporter: robin@catalyst.net.nz Hardware: All Status: NEW Version: master Component: Reports Product: Koha If you create a report with <<Enter a date|date>>, the resulting date picker interface when running the report doesn't force dates to ISO form, instead they are created using the date format of the system. This is passed to mysql which complains about the format not being right, understandably. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11605&action=edit Bug 8596 - Reports interface date picker doesn't force ISO formatted dates Datepickers follow Koha's preference for date format, but the guided reports system doesn't intelligently handle different date formats. ISO is required. This patch adds some additional configuration to override the date format. To test, create a guided or SQL report which takes a date parameter. The datepicker fields should return an ISO-formatted date. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11605|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11645&action=edit [SIGNED-OFF] Bug 8596 - Reports interface date picker doesn't force ISO formatted dates Datepickers follow Koha's preference for date format, but the guided reports system doesn't intelligently handle different date formats. ISO is required. This patch adds some additional configuration to override the date format. To test, create a guided or SQL report which takes a date parameter. The datepicker fields should return an ISO-formatted date. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Adds date formatting according to datepicker's conventions (which do yyyy-mm-dd even though it says yy-mm-dd). Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA It would have been better to handle the syspref properly, but I agree it would have required a larger rewrite. And, as we're dealing with reports/sql/..., which is used by a limited number of patrons, I agree it's fair to force iso. Patch pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org