[Bug 8626] New: Encoding problem with = in cart emails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 Priority: P5 - low Change sponsored?: --- Bug ID: 8626 Assignee: oleonard@myacpl.org Blocks: 8621 Summary: Encoding problem with = in cart emails Severity: normal Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: OPAC Product: Koha I have testes this with Outlook Web Access and Thunderbird so far and both mail clients show the problem: Original URL: http://localhost/cgi-bin/koha/opac-detail.pl?biblionumber=5100 Thunderbird/OWA: http://localhost/cgi-bin/koha/opac-detail.pl?biblionumberQ00 I have tracked down the problem with the URLs to it being a problem with encoding and the = character. Currently we have following line sin opac-sendbasket.pl: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It seems that with this setting the = is interpreted as the beginning of a special character. So if you have a URL or Title containing = it will not be displayed correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #1 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #0)
I have testes this with Outlook Web Access and Thunderbird so far and both mail clients show the problem:
Original URL: http://localhost/cgi-bin/koha/opac-detail.pl?biblionumber=5100
Thunderbird/OWA: http://localhost/cgi-bin/koha/opac-detail.pl?biblionumberQ00
I have tracked down the problem with the URLs to it being a problem with encoding and the = character.
Currently we have following line sin opac-sendbasket.pl:
MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It seems that with this setting the = is interpreted as the beginning of a special character. So if you have a URL or Title containing = it will not be displayed correctly.
hi Cait i think we could fix this bug using Email::Simple http://search.cpan.org/~rjbs/Email-Simple-2.102/lib/Email/Simple.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 147 $body = encode_qp($1); Seems to work right, but needs more testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- 2 options Either we don't set it to quoted-printable in the mail headers. Or we set that, and encode. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After deleting the line "Content-Transfer-Encoding: quoted-printable" it also worked nicely in my tests. Can we do that or what is the right value to be used with utf-8 data? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 11594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11594&action=edit Bug 8626: Fix encoding in cart emails for use of quoted-printable When using quoted-printable data needs to be encoded accordingly. Content-Transfer-Encoding: quoted-printable Without the patch = in URLs or data will be interpreted as the beginning of a special character resulting in broken URLs. To test: - Check diacritics in records display correctly - Check various URLs with = to make sure they all work correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11594|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11610&action=edit Bug 8626: Fix encoding in cart emails for use of quoted-printable When using quoted-printable data needs to be encoded accordingly. Content-Transfer-Encoding: quoted-printable Without the patch = in URLs or data will be interpreted as the beginning of a special character resulting in broken URLs. To test: - Check diacritics in records display correctly - Check various URLs with = to make sure they all work correctly Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> This is only a partial fix, as the subject line is not encoded, but it is a huge improvement over what it was before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: It seems the good way to do that (already used in basket/sendbasket.pl, opac/opac-sendshelf.pl and virtualshelves/sendshelf.pl). Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8626 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org