[Bug 37187] New: 2 problems with label batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Bug ID: 37187 Summary: 2 problems with label batches Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: isabel.pineda@ds.edu.sv QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl After updating from version 23.11 to 24.05, I found 2 problems with label batches: 1. In the item view of a book, the option "Actions > Print label" is not working anymore. I have to go to the Cataloging module to create a new label batch from there. 2. I cannot delete label batches anymore: The "Delete"-button in the list of label batches is not working. And inside the label batch, the button "Delete label batch" is not working either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|2 problems with label |Label batches cannot be |batches |deleted and not created | |from the item editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Keywords| |regression Summary|Label batches cannot be |Label batches cannot be |deleted and not created |deleted |from the item editor | Depends on| |36192 Component|Cataloging |Label/patron card printing Severity|normal |major Assignee|koha-bugs@lists.koha-commun |cnighswonger@foundations.ed |ity.org |u --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- I split number 1 off to bug 37192 because even though they are caused by the same thing (the giant CSRF protection bug), fixing them is going to be different sorts of fixes in widely separated places. The problem with deleting batches is that the script expects the op cud-delete, correctly, and so the request has to be POSTed, but both places in the UI that delete batches just do a GET with ?op=delete. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Not a workaround I'd be happy with, but while testing a patch for bug 37192 I noticed that if you delete all the items in a batch (easy enough if there's only one) and then just walk away, the empty batch is automatically deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Phil, I was pondering splitting yesterday - it's better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main Assignee|cnighswonger@foundations.ed |oleonard@myacpl.org |u | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168156&action=edit Bug 37187: Fix deletion of label batches and label templates This patch uses the new form-submit JS to convert the label management deletion link from a GET operation to POST. To test, apply the patch and go to Cataloging -> Label creator. - Click Manage -> Label batches. Create a batch if necessary. - Click the "Delete" button in the "Actions" column. You should get a confirmation message, "Are you sure you want to delete this?" - Test both the confirming and cancelling. - Perform the same test with Manage -> Label templates. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Because labels seem to always have at least two ways to do the same thing, that fixes the delete button in the list of batches, but not the delete button in label-edit-batch.pl that you use (when you remember to use it) in the workflow "add items to batch, export batch to actually print, delete batch" all in the editor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Phil Ringnalda from comment #5)
not the delete button in label-edit-batch.pl
Quite right, I didn't read the report carefully! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168156|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168179&action=edit Bug 37187: Fix deletion of label batches and label templates This patch uses the new form-submit JS to convert the label management deletion link from a GET operation to POST. To test, apply the patch and go to Cataloging -> Label creator. - Click Manage -> Label batches. Create a batch if necessary. - Click the "Delete" button in the "Actions" column. You should get a confirmation message, "Are you sure you want to delete this?" - Test both the confirming and cancelling. - Perform the same test with Manage -> Label templates. - From the Manage -> Label batches page, click "edit" on one of the batches. - Right above the "Items in batch number X" is a toolbar which should have a button, "Delete batch." Test that it works correctly to delete the batch. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168179|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 168182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168182&action=edit Bug 37187: Fix deletion of label batches and label templates This patch uses the new form-submit JS to convert the label management deletion link from a GET operation to POST. To test, apply the patch and go to Cataloging -> Label creator. - Click Manage -> Label batches. Create a batch if necessary. - Click the "Delete" button in the "Actions" column. You should get a confirmation message, "Are you sure you want to delete this?" - Test both the confirming and cancelling. - Perform the same test with Manage -> Label templates. - From the Manage -> Label batches page, click "edit" on one of the batches. - Right above the "Items in batch number X" is a toolbar which should have a button, "Delete batch." Test that it works correctly to delete the batch. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168182|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 168226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168226&action=edit Bug 37187: Fix deletion of label batches and label templates This patch uses the new form-submit JS to convert the label management deletion link from a GET operation to POST. To test, apply the patch and go to Cataloging -> Label creator. - Click Manage -> Label batches. Create a batch if necessary. - Click the "Delete" button in the "Actions" column. You should get a confirmation message, "Are you sure you want to delete this?" - Test both the confirming and cancelling. - Perform the same test with Manage -> Label templates. - From the Manage -> Label batches page, click "edit" on one of the batches. - Right above the "Items in batch number X" is a toolbar which should have a button, "Delete batch." Test that it works correctly to delete the batch. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Ignoring a minor inconsistency that seems to be innocent: data-action="/cgi-bin/koha/labels/label-manage.pl" data-action="label-manage.pl" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Keywords|rel_24_05_candidate | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Summary|Label batches cannot be |Label batches and label |deleted |templates cannot be deleted Text to go in the| |This fixes the manage label release notes| |batches and label templates | |pages so that they can now | |be deleted. (This is | |related to the CSRF changes | |added in Koha 24.05 to | |improve form security.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from David Nind <david@davidnind.com> --- No changes require to the manual - fixes something not working (no UI changes, so no screenshot updates required). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37187 Bug 37187 depends on bug 36192, which changed state. Bug 36192 Summary: [OMNIBUS] CSRF Protection for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org