[Bug 16381] New: Fix capitalization on tags review page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381 Bug ID: 16381 Summary: Fix capitalization on tags review page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50972&action=edit Bug 16381: Fix capitalization on tags review page - Fixes capitalization of the sub heading "Displaying ... terms" - Fixes button label of "Test" To test: - Look at all, approved, rejected, pending tags and check the line below the heading "Tags" - "Displaying..." - Check a term using the search box on the left side Before the patch: Test - Processing... - test After the patch this should be Test again in the end. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50972|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 50982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50982&action=edit Bug 16381: Fix capitalization on tags review page - Fixes capitalization of the sub heading "Displaying ... terms" - Fixes button label of "Test" To test: - Look at all, approved, rejected, pending tags and check the line below the heading "Tags" - "Displaying..." - Check a term using the search box on the left side Before the patch: Test - Processing... - test After the patch this should be Test again in the end. Capitalization looks good. QA tools complain about tabs, but there are loads of tabs all over review.tt. Proper formatting of the whole file could be done in a separate bug. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16394 CC| |veron@veron.ch Status|Needs Signoff |Signed Off --- Comment #3 from Marc Véron <veron@veron.ch> --- Regarding tab chars see: Bug 16394 - Fix formatting of review.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16394 [Bug 16394] Fix formatting of review.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50982|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50998&action=edit Bug 16381: Fix capitalization on tags review page - Fixes capitalization of the sub heading "Displaying ... terms" - Fixes button label of "Test" To test: - Look at all, approved, rejected, pending tags and check the line below the heading "Tags" - "Displaying..." - Check a term using the search box on the left side Before the patch: Test - Processing... - test After the patch this should be Test again in the end. Capitalization looks good. QA tools complain about tabs, but there are loads of tabs all over review.tt. Proper formatting of the whole file could be done in a separate bug. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51022&action=edit Bug 16381 [QA Followup] - Wrap string for translations Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.05. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org