[Bug 16340] New: JS variable in opac-bottom.inc is declared two times
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340 Bug ID: 16340 Summary: JS variable in opac-bottom.inc is declared two times Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 16243 Dlecared JS variable in opac-bottom.inc delcared two times var found when working with ENH 16243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243 [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 50655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50655&action=edit Bug 16340: JS variable in opac-bottom.inc is declared two times MSG_NO_RECORD_SELECTED declared two times To test: Go to cart and list (virtual shelves) in OPAC and verify if those pages work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50655|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 50690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50690&action=edit Bug 16340: JS variable in opac-bottom.inc is declared two times MSG_NO_RECORD_SELECTED declared two times To test: Go to cart and list (virtual shelves) in OPAC and verify if those pages work as expected NOTE: Particularly clicking place hold when you don't select anything. Eyeballs very well. Line 123 vs 130 before patch. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50690|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50724&action=edit Bug 16340: JS variable in opac-bottom.inc is declared two times MSG_NO_RECORD_SELECTED declared two times To test: Go to cart and list (virtual shelves) in OPAC and verify if those pages work as expected Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Blocks| |16243 Depends on|16243 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243 [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.05, thanks Hector! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16340 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org