[Bug 33550] New: Rename Patron restrictions administration page 'Patron restriction types'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Bug ID: 33550 Summary: Rename Patron restrictions administration page 'Patron restriction types' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This is a suggestion because I think it would make more sense (we have attribute types, credit types, debit types, etc.) but also to help with translations. Right now, the term for a restriction on a specific patron and the term for the restriction type administration are the same, but they don't mean the same thing. #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt:130 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:38 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:57 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:167 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:218 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:1411 #: koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc:58 #, c-format msgid "Patron restrictions" msgstr "Restrictions de l'utilisateur" In memberentrygen, it's to add a restriction to a specific patron In admin-home/menu and restrictions, it's to add restriction types Therefore, I think the administration page should be named 'Patron restriction types'. Opinions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Make patron restrictions user definable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 149780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149780&action=edit Bug 33550: Rename Patron restrictions administration page to Patron restriction types This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration. To test: 0. Apply patch 1. Enable PatronRestrictionTypes 2. Go to Administration 3. Check the name, spelling/grammar of the following elements * Section name * Section caption 4. Click 'Patron restriction types' 5. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Left hand side menu * 'New' button * Page heading 6. Click 'New restriction type' 7. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 8. Fill out the form and click 'Save' to create a new restriction type * Dialog message ('Restriction type added') 9. Click 'New restriction type' 10. Enter the same code as last time * Warning ('Restriction type code is already in use') 11. Click 'Cancel' 12. Click 'Edit' next to one of the types 13. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 14. Without changing anything, click 'Save' * Warning ('Restriction type label is already in use') 15. Change the label and click 'Save' * Dialog message ('Restriction type updated') 16. Click 'Delete' next to one of the types 17. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading * Delete button 18. Click 'Delete this restriction type' * Dialog message ('Restriction type deleted') -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Marius <marius.mandrescu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Marius <marius.mandrescu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149780|0 |1 is obsolete| | --- Comment #2 from Marius <marius.mandrescu@inlibro.com> --- Created attachment 149807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149807&action=edit Bug 33550: Rename Patron restrictions administration page to Patron restriction types This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration. To test: 0. Apply patch 1. Enable PatronRestrictionTypes 2. Go to Administration 3. Check the name, spelling/grammar of the following elements * Section name * Section caption 4. Click 'Patron restriction types' 5. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Left hand side menu * 'New' button * Page heading 6. Click 'New restriction type' 7. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 8. Fill out the form and click 'Save' to create a new restriction type * Dialog message ('Restriction type added') 9. Click 'New restriction type' 10. Enter the same code as last time * Warning ('Restriction type code is already in use') 11. Click 'Cancel' 12. Click 'Edit' next to one of the types 13. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 14. Without changing anything, click 'Save' * Warning ('Restriction type label is already in use') 15. Change the label and click 'Save' * Dialog message ('Restriction type updated') 16. Click 'Delete' next to one of the types 17. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading * Delete button 18. Click 'Delete this restriction type' * Dialog message ('Restriction type deleted') Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Putting this back to Needs signoff since Marius works with me :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Unfortunately this patch set no longer applies cleanly to current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149807|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150229&action=edit Bug 33550: Rename Patron restrictions administration page to Patron restriction types This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration. To test: 0. Apply patch 1. Enable PatronRestrictionTypes 2. Go to Administration 3. Check the name, spelling/grammar of the following elements * Section name * Section caption 4. Click 'Patron restriction types' 5. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Left hand side menu * 'New' button * Page heading 6. Click 'New restriction type' 7. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 8. Fill out the form and click 'Save' to create a new restriction type * Dialog message ('Restriction type added') 9. Click 'New restriction type' 10. Enter the same code as last time * Warning ('Restriction type code is already in use') 11. Click 'Cancel' 12. Click 'Edit' next to one of the types 13. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 14. Without changing anything, click 'Save' * Warning ('Restriction type label is already in use') 15. Change the label and click 'Save' * Dialog message ('Restriction type updated') 16. Click 'Delete' next to one of the types 17. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading * Delete button 18. Click 'Delete this restriction type' * Dialog message ('Restriction type deleted') Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150230&action=edit Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried rebasing. Not sure what I'm doing so crossing my fingers it worked ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Hi Caroline. Your rebase worked, as I was able to successfully apply the patch! Some minor things I noted when testing: 1. Administration page: There is a full stop at the end of the description. No other administration menu options on the administration have this. 2. Page title when modifying and deleting a restriction type: in the page title that shows in the browser tab, the <span> tag is visible and has ' either side of it. For example: Modify restriction type '<span>Test patron restriction type</span>' > Patron restriction types > Administration > Koha. Note that this was the case before the patch was applied. 3. Breadcrumb when deleting a restriction type: I'm not sure I've have seen a question mark in breadcrumbs before, except for this one (although I haven't looked very hard). Maybe the breadcrumb should be "Confirm restriction type deletion", to match the page title. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> ---
2. Page title when modifying and deleting a restriction type: in the page title that shows in the browser tab, the <span> tag is visible and has ' either side of it. For example: Modify restriction type '<span>Test patron restriction type</span>' > Patron restriction types > Administration > Koha. Note that this was the case before the patch was applied.
I believe this problem is fixed in Bug 33551. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33551 --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass from comment #9)
2. Page title when modifying and deleting a restriction type: in the page title that shows in the browser tab, the <span> tag is visible and has ' either side of it. For example: Modify restriction type '<span>Test patron restriction type</span>' > Patron restriction types > Administration > Koha. Note that this was the case before the patch was applied.
I believe this problem is fixed in Bug 33551.
Thanks Lucas for identifying that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150312&action=edit Bug 33550: Remove period in patron restriction type description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 150313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150313&action=edit Bug 33550: Remove question mark in breadcrumb -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi David, Thanks for you input! I removed the period in the admin section description and changed the breadcrumb of the delete page to "Delete restriction type 'something'" to match the Modify page. Let me know if it worked! Caroline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150229|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 150316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150316&action=edit Bug 33550: Rename Patron restrictions administration page to Patron restriction types This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration. To test: 0. Apply patch 1. Enable PatronRestrictionTypes 2. Go to Administration 3. Check the name, spelling/grammar of the following elements * Section name * Section caption 4. Click 'Patron restriction types' 5. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Left hand side menu * 'New' button * Page heading 6. Click 'New restriction type' 7. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 8. Fill out the form and click 'Save' to create a new restriction type * Dialog message ('Restriction type added') 9. Click 'New restriction type' 10. Enter the same code as last time * Warning ('Restriction type code is already in use') 11. Click 'Cancel' 12. Click 'Edit' next to one of the types 13. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 14. Without changing anything, click 'Save' * Warning ('Restriction type label is already in use') 15. Change the label and click 'Save' * Dialog message ('Restriction type updated') 16. Click 'Delete' next to one of the types 17. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading * Delete button 18. Click 'Delete this restriction type' * Dialog message ('Restriction type deleted') Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150230|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 150317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150317&action=edit Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150312|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 150318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150318&action=edit Bug 33550: Remove period in patron restriction type description Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150313|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 150319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150319&action=edit Bug 33550: Remove question mark in breadcrumb Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #18 from David Nind <david@davidnind.com> --- (In reply to Caroline Cyr La Rose from comment #13)
Hi David,
Thanks for you input! I removed the period in the admin section description and changed the breadcrumb of the delete page to "Delete restriction type 'something'" to match the Modify page.
Let me know if it worked!
Caroline
Thanks Caroline! It worked 8-) David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150316|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150900&action=edit Bug 33550: Rename Patron restrictions administration page to Patron restriction types This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration. To test: 0. Apply patch 1. Enable PatronRestrictionTypes 2. Go to Administration 3. Check the name, spelling/grammar of the following elements * Section name * Section caption 4. Click 'Patron restriction types' 5. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Left hand side menu * 'New' button * Page heading 6. Click 'New restriction type' 7. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 8. Fill out the form and click 'Save' to create a new restriction type * Dialog message ('Restriction type added') 9. Click 'New restriction type' 10. Enter the same code as last time * Warning ('Restriction type code is already in use') 11. Click 'Cancel' 12. Click 'Edit' next to one of the types 13. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 14. Without changing anything, click 'Save' * Warning ('Restriction type label is already in use') 15. Change the label and click 'Save' * Dialog message ('Restriction type updated') 16. Click 'Delete' next to one of the types 17. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading * Delete button 18. Click 'Delete this restriction type' * Dialog message ('Restriction type deleted') Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=33500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150317|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150901&action=edit Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=33500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150318|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150902&action=edit Bug 33550: Remove period in patron restriction type description Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=33500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150319|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150903&action=edit Bug 33550: Remove question mark in breadcrumb Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=33500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150904&action=edit Bug 33550: (QA follow-up) Switch from double to single quotes in text As we use single quotes in general and also in breadcrumbs and page title on this specific page, we shoudl also use them for the main content: Are you sure you want to delete 'T'? Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=33500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Documentation| |Philip Orr contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/766 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org