[Bug 31262] New: Curbside pickups - disable dates without slots
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Bug ID: 31262 Summary: Curbside pickups - disable dates without slots Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 30650 We could remove from the date picker widget the dates that do not have available slots. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Convert the Curbside Pickup plugin to Koha core -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138403&action=edit Bug 31262: Disable dates in the past for curbside pickups When creating a new pickup the dates in the past won't display any available slots. It would be better to disable them in the date picker. Test plan: Setup curbside pickups for your library (see bug 30650 test plan if needed) Create a new pickup (staff and OPAC) and confirm that the date picker widget has the dates in the past disabled. QA note: More work would be needed to sync calendar.inc code between OPAC and staff. Also note that the "clear date" code wasn't needed (please confirm). Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143211&action=edit Bug 31262: Curbside pickup - Remove day without slots We disable dates from the date picker that do not have slots defined in the configuration. Note that dates that have slots configured but none are available will still be displayed. To implement that we would need to calculate the availability for all the dates displayed on the widget (1 month) and that will (certainly) slow down considerabily the UI. Test plan: Configure curbside pickup for a given library. Define slots for several days of the week (not all). Schedule a pickup and confirm that only the days with slots defined are available in the date picker widget -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143211|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143212&action=edit Bug 31262: Curbside pickup - Remove day without slots We disable dates from the date picker that do not have slots defined in the configuration. Note that dates that have slots configured but none are available will still be displayed. To implement that we would need to calculate the availability for all the dates displayed on the widget (1 month) and that will (certainly) slow down considerabily the UI. Test plan: Configure curbside pickup for a given library. Define slots for several days of the week (not all). Schedule a pickup and confirm that only the days with slots defined are available in the date picker widget Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143212|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 143294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143294&action=edit Bug 31262: Curbside pickup - Remove day without slots We disable dates from the date picker that do not have slots defined in the configuration. Note that dates that have slots configured but none are available will still be displayed. To implement that we would need to calculate the availability for all the dates displayed on the widget (1 month) and that will (certainly) slow down considerabily the UI. Test plan: Configure curbside pickup for a given library. Define slots for several days of the week (not all). Schedule a pickup and confirm that only the days with slots defined are available in the date picker widget Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143294|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143610&action=edit Bug 31262: Curbside pickup - Remove day without slots We disable dates from the date picker that do not have slots defined in the configuration. Note that dates that have slots configured but none are available will still be displayed. To implement that we would need to calculate the availability for all the dates displayed on the widget (1 month) and that will (certainly) slow down considerabily the UI. Test plan: Configure curbside pickup for a given library. Define slots for several days of the week (not all). Schedule a pickup and confirm that only the days with slots defined are available in the date picker widget Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32653 [Bug 32653] Curbside pickups - wrong dates available at the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Bug 31262 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org