[Bug 32111] New: Cannot schedule a pickup at the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Bug ID: 32111 Summary: Cannot schedule a pickup at the OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Circulation Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 30650, 30718 The date input is always disabled and it's not possible to select or enter a date. git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 [Bug 30718] Use flatpickr's altInput option everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143181&action=edit Bug 32111: Remove disabled from date input for curbside pickup The date input is always disabled and it's not possible to select or enter a date. git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true" I don't really know what's happening here, but it's impossible to interact with the date widget if the input is disabled when it's initialized. The solution I have here is to play with hide/show instead of disabled. Other suggestions welcome. Test plan: Schedule a curbside pickup from the OPAC and confirm that the date input is working as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261 [Bug 31261] Curbside pickups - remove slots in the past -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143181|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 143184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143184&action=edit Bug 32111: Remove disabled from date input for curbside pickup The date input is always disabled and it's not possible to select or enter a date. git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true" I don't really know what's happening here, but it's impossible to interact with the date widget if the input is disabled when it's initialized. The solution I have here is to play with hide/show instead of disabled. Other suggestions welcome. Test plan: Schedule a curbside pickup from the OPAC and confirm that the date input is working as expected. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143184|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143185&action=edit Bug 32111: Remove disabled from date input for curbside pickup The date input is always disabled and it's not possible to select or enter a date. git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true" I don't really know what's happening here, but it's impossible to interact with the date widget if the input is disabled when it's initialized. The solution I have here is to play with hide/show instead of disabled. Other suggestions welcome. Test plan: Schedule a curbside pickup from the OPAC and confirm that the date input is working as expected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143185|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143492&action=edit Bug 32111: Remove disabled from date input for curbside pickup The date input is always disabled and it's not possible to select or enter a date. git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true" I don't really know what's happening here, but it's impossible to interact with the date widget if the input is disabled when it's initialized. The solution I have here is to play with hide/show instead of disabled. Other suggestions welcome. Test plan: Schedule a curbside pickup from the OPAC and confirm that the date input is working as expected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 [Bug 32652] Standardize slots selection between staff interface and opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32652 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 [Bug 32652] Standardize slots selection between staff interface and opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Bug 32111 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org