[Bug 33897] New: Use template wrapper for tabs: OPAC bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Bug ID: 33897 Summary: Use template wrapper for tabs: OPAC bibliographic detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 33891 Blocks: 32571 Continuing the work of Bug 32571, I would like to update the OPAC bibliographic detail page page use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 [Bug 33891] Use template wrapper for tabs: OPAC advanced search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151991&action=edit Bug 33897: Use template wrapper for tabs: OPAC bibliographic detail page This patch updates the OPAC bibliographic detail page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and locate a bibliographic record. View the detail page. Verify that tabs are working, including all the options: - Holdings - Other holdings (If OpacSeparateHoldings is enabled) - Descriptions (MARC notes) - Subscriptions - Serial collection (UNIMARC, untested) - Components (If ShowComponentRecords is enabled. See Bug 11175 for sample record) - Comments - Editions (OPACFRBRizeEditions) - Html5media (If HTML5MediaEnabled is on. See Bug 8377 for sample records) - Images (If OPACLocalCoverImages is enabled) - NovelistSelect - Author identifiers (Witgh OPACAuthorIdentifiers enabled, see Bug 29897) Bonus points for testing these tabs for which I don't have credentials: - Syndetics TOC - Syndetics Excerpt - Syndetics Reviews - Syndetics AuthorNotes - LibraryThing for Libraries (with LibraryThingForLibrariesTabbedView set to "in tabs.") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151991|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152016&action=edit Bug 33897: Use template wrapper for tabs: OPAC bibliographic detail page This patch updates the OPAC bibliographic detail page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and locate a bibliographic record. View the detail page. Verify that tabs are working, including all the options: - Holdings - Other holdings (If OpacSeparateHoldings is enabled) - Descriptions (MARC notes) - Subscriptions - Serial collection (UNIMARC, untested) - Components (If ShowComponentRecords is enabled. See Bug 11175 for sample record) - Comments - Editions (OPACFRBRizeEditions) - Html5media (If HTML5MediaEnabled is on. See Bug 8377 for sample records) - Images (If OPACLocalCoverImages is enabled) - NovelistSelect - Author identifiers (Witgh OPACAuthorIdentifiers enabled, see Bug 29897) Bonus points for testing these tabs for which I don't have credentials: - Syndetics TOC - Syndetics Excerpt - Syndetics Reviews - Syndetics AuthorNotes - LibraryThing for Libraries (with LibraryThingForLibrariesTabbedView set to "in tabs.") Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- This looks good. I was able to test with Syndetics but not LibraryThing for Libraries. Unrelated thing: I notices a modal ( #libraryInfoModal ) that is outside of the page's HTML tags. So I filed Bug 33902. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33902 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this patch breaks the opacSerialDefaultTab functionality. When it's set to subscription, the subscription tab should be active when loading the detail page when a subscription exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152262&action=edit Bug 33897: (QA follow-up) Correct code for tab selection This patch corrects the code for selecting tabs other than the first tab. To test, apply the patch and view the bibliographic detail page for a serial record and with various settings of the opacSerialDefaultTab system preference. If you select "subscriptions tab" the subscriptions tab should be active by default. You can also enable html5media and view a record with html5media information and no holdings. The media tab should be displayed by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152016|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152268&action=edit Bug 33897: Use template wrapper for tabs: OPAC bibliographic detail page This patch updates the OPAC bibliographic detail page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and locate a bibliographic record. View the detail page. Verify that tabs are working, including all the options: - Holdings - Other holdings (If OpacSeparateHoldings is enabled) - Descriptions (MARC notes) - Subscriptions - Serial collection (UNIMARC, untested) - Components (If ShowComponentRecords is enabled. See Bug 11175 for sample record) - Comments - Editions (OPACFRBRizeEditions) - Html5media (If HTML5MediaEnabled is on. See Bug 8377 for sample records) - Images (If OPACLocalCoverImages is enabled) - NovelistSelect - Author identifiers (Witgh OPACAuthorIdentifiers enabled, see Bug 29897) Bonus points for testing these tabs for which I don't have credentials: - Syndetics TOC - Syndetics Excerpt - Syndetics Reviews - Syndetics AuthorNotes - LibraryThing for Libraries (with LibraryThingForLibrariesTabbedView set to "in tabs.") Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152262|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152269&action=edit Bug 33897: (QA follow-up) Correct code for tab selection This patch corrects the code for selecting tabs other than the first tab. To test, apply the patch and view the bibliographic detail page for a serial record and with various settings of the opacSerialDefaultTab system preference. If you select "subscriptions tab" the subscriptions tab should be active by default. You can also enable html5media and view a record with html5media information and no holdings. The media tab should be displayed by default. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org