[Bug 33500] New: Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Bug ID: 33500 Summary: Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: -Set the sys pref 'RecordLocalUseOnReturn' to 'record'. -prove -v /kohadevbox/koha/t/db_dependent/Circulation.t # Subtest: Tests for BlockReturnOfWithdrawnItems 1..1 not ok 1 - Item returned as withdrawn, no other messages # Failed test 'Item returned as withdrawn, no other messages' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 5816. # Structures begin differing at: # $got->[1]{LocalUse} = '1' # $expected->[1]{LocalUse} = Does not exist # Looks like you failed 1 test of 1. not ok 65 - Tests for BlockReturnOfWithdrawnItems # Subtest: Tests for transfer not in transit # Failed test 'Tests for BlockReturnOfWithdrawnItems' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 5819. 1..2 not ok 1 - Item is reported to have been transferred # Failed test 'Item is reported to have been transferred' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 5837. # Structures begin differing at: # $got->[1]{LocalUse} = '1' # $expected->[1]{LocalUse} = Does not exist ok 2 - The datesent field is populated, i.e. transfer is initiated # Looks like you failed 1 test of 2. not ok 66 - Tests for transfer not in transit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16122 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 [Bug 16122] Item record needs to keep Local Use count -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152346&action=edit Bug 33500: Account for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152346|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 152347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152347&action=edit Bug 33500: Account for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152347|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152352&action=edit Bug 33500: Add tests for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152352|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau@gmail.com> --- Created attachment 152355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152355&action=edit Bug 33500: Add tests for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Filled assignee :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152355|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152623&action=edit Bug 33500: Add tests for RecordLocalUseOnReturn To test: 1. Turn on RecordLocalUseOnReturn 2. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 3. Tests fail. 4. Apply patch 5. prove -v /kohadevbox/koha/t/db_dependent/Circulation.t 6. Tests pass. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org