https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 166829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166829&action=edit Bug 36798: Add ability to search across all ISBNs using the ISBN-search With the Bug 36574 we added a new ES search field isbn-all which makes it possible to find records with the content of the subfield 020 $z (invalid/cancelled ISBN) in general search (by keyword). But still, when performing a search with ISBN-search these records will not be found. Since some libraries deliberately want to find records with only 020 $a with ISBN-search, a system preference would be needed here to be able to customize the ISBN search. The same for ISSNs, with one system preference. Test plan: ========== (ISBN) ------ 1. Have the ktd with with ES enabled. 2. With standard ktd test data, try to perform a ISBN search from Advanced search for 9780141930848. You should get no results. In the general search input field (on the main page) try a search nb:9780141930848 and/or isbn:9780141930848 - you should get no results. 3. Apply the patch, restart_all. 4. Repeat p. 2 -- you should still get no results. 5. Enable SearchCancelAndInvalidISBNandISSN syspref. 6. Repeat p. 2 -- now you should get one record (having 9780141930848 in 020 $z). (ISSN) ------ 0. Return to main, delete the bug branch, reset_all == start from fresh. 1. Have the ktd with with ES enabled. 2. With standard ktd test data, try to perform a ISSN search from Advanced search for 1089-6891. You should get no results. In the general search input field (on the main page) try a search ns:1089-6891 and/or issn:1089-6891 - you should get no results. 3. Apply the patch, restart_all. If you have had to apply also the bug 36727, reindex ES with: koha-elasticsearch --rebuild -r -d kohadev (there is a modification of mappings.yaml) 4. Repeat p. 2 -- you should still get no results. 5. Enable SearchCancelAndInvalidISBNandISSN syspref. 6. Repeat p. 2 -- now you should get one record (having 1089-6891 in 022 $y). Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |aleisha@catalyst.net.nz, | |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ability to search across |Add ability to search |all ISBNs using the |across all ISBNs using the |ISBN-search |ISBN-search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166828|0 |1 is obsolete| | --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 166836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166836&action=edit Bug 36798: Add 'SearchCancelAndInvalidISBNandISSN' system preference This patch adds a new system preference SearchCancelAndInvalidISBNandISSN: whether to search for cancelled / invalid forms of ISBN/ISSN when performing ISBN/ISSN search. (By default, with ES, only valid forms, i.e. 020 $a / 022 $a are considered). Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166830|0 |1 is obsolete| | --- Comment #6 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 166838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166838&action=edit Bug 36798: Unit tests Added unit tests. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Bug 36798 depends on bug 36727, which changed state. Bug 36727 Summary: Add incorrect ISSN to Elasticsearch index mappings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36727 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 --- Comment #9 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 171907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171907&action=edit Bug 36798: Add ability to search across all ISBNs using the ISBN-search With the Bug 36574 we added a new ES search field isbn-all which makes it possible to find records with the content of the subfield 020 $z (invalid/cancelled ISBN) in general search (by keyword). But still, when performing a search with ISBN-search these records will not be found. Since some libraries deliberately want to find records with only 020 $a with ISBN-search, a system preference would be needed here to be able to customize the ISBN search. The same for ISSNs, with one system preference. Test plan: ========== (ISBN) ------ 1. Have the ktd with with ES enabled. 2. With standard ktd test data, try to perform a ISBN search from Advanced search for 9780141930848. You should get no results. In the general search input field (on the main page) try a search nb:9780141930848 and/or isbn:9780141930848 - you should get no results. 3. Apply the patch, restart_all. 4. Repeat p. 2 -- you should still get no results. 5. Enable SearchCancelledAndInvalidISBNandISSN syspref. 6. Repeat p. 2 -- now you should get one record (having 9780141930848 in 020 $z). (ISSN) ------ 0. Return to main, delete the bug branch, reset_all == start from fresh. 1. Have the ktd with with ES enabled. 2. With standard ktd test data, try to perform a ISSN search from Advanced search for 1089-6891. You should get no results. In the general search input field (on the main page) try a search ns:1089-6891 and/or issn:1089-6891 - you should get no results. 3. Apply the patch, restart_all. If you have had to apply also the bug 36727, reindex ES with: koha-elasticsearch --rebuild -r -d kohadev (there is a modification of mappings.yaml) 4. Repeat p. 2 -- you should still get no results. 5. Enable SearchCancelledAndInvalidISBNandISSN syspref. 6. Repeat p. 2 -- now you should get one record (having 1089-6891 in 022 $y). Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 --- Comment #11 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Lucas Gass from comment #7)

Sorry Janusz, this no longer applies cleanly. Good new, seems like a simple rebase of searching.pref.

Thanks, Lucas. Sure--it has been four months since the patch was ready, so no wonder... Rebased + tiny spelling correction. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171907|0 |1 is obsolete| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171936&action=edit Bug 36798: Add ability to search across all ISBNs using the ISBN-search With the Bug 36574 we added a new ES search field isbn-all which makes it possible to find records with the content of the subfield 020 $z (invalid/cancelled ISBN) in general search (by keyword). But still, when performing a search with ISBN-search these records will not be found. Since some libraries deliberately want to find records with only 020 $a with ISBN-search, a system preference would be needed here to be able to customize the ISBN search. The same for ISSNs, with one system preference. Test plan: ========== (ISBN) ------ 1. Have the ktd with with ES enabled. 2. With standard ktd test data, try to perform a ISBN search from Advanced search for 9780141930848. You should get no results. In the general search input field (on the main page) try a search nb:9780141930848 and/or isbn:9780141930848 - you should get no results. 3. Apply the patch, restart_all. 4. Repeat p. 2 -- you should still get no results. 5. Enable SearchCancelledAndInvalidISBNandISSN syspref. 6. Repeat p. 2 -- now you should get one record (having 9780141930848 in 020 $z). (ISSN) ------ 0. Return to main, delete the bug branch, reset_all == start from fresh. 1. Have the ktd with with ES enabled. 2. With standard ktd test data, try to perform a ISSN search from Advanced search for 1089-6891. You should get no results. In the general search input field (on the main page) try a search ns:1089-6891 and/or issn:1089-6891 - you should get no results. 3. Apply the patch, restart_all. If you have had to apply also the bug 36727, reindex ES with: koha-elasticsearch --rebuild -r -d kohadev (there is a modification of mappings.yaml) 4. Repeat p. 2 -- you should still get no results. 5. Enable SearchCancelledAndInvalidISBNandISSN syspref. 6. Repeat p. 2 -- now you should get one record (having 1089-6891 in 022 $y). Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have to admit when we talked about this at the hackfest, I was thinking about a slightly different solution, more in line with how the system preferences *NumbersPreferPhrase work. They work on the GUI level, changing the index used in the drop-downs and search options. With this patch, whenever I use the index "isbn" in "Expert search" it will also be turned into isbn-all, if I understand how this works correctly. Can you confirm? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |The new system preference release notes| |`SearchCancelledAndInvalidI | |SBNandISSN` allows to | |include invalid and | |cancelled ISBNs (MARC21 | |020/022 $z) in searches for | |ISBN and ISSN. --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #16)

I have to admit when we talked about this at the hackfest, I was thinking about a slightly different solution, more in line with how the system preferences *NumbersPreferPhrase work. They work on the GUI level, changing the index used in the drop-downs and search options.

With this patch, whenever I use the index "isbn" in "Expert search" it will also be turned into isbn-all, if I understand how this works correctly. Can you confirm?

*ping* -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Janusz Kaczmarek from comment #18)

(In reply to Katrin Fischer from comment #17)

...

(In reply to Katrin Fischer from comment #16)

...

I have to admit when we talked about this at the hackfest, I was thinking about a slightly different solution, more in line with how the system preferences *NumbersPreferPhrase work. They work on the GUI level, changing the index used in the drop-downs and search options.

With this patch, whenever I use the index "isbn" in "Expert search" it will also be turned into isbn-all, if I understand how this works correctly. Can you confirm?

*ping*

I am sorry I missed this.

I am a bit lost. My intention and understanding is that the patch works exactly as you described for *NumbersPreferPhrase. If SearchCancelledAndInvalidISBNandISSN is on, the patch adds '-all' to isbn/issn search-field-name (cf. corrections in QueryBuilder.pm), thus changing the search-field (in Zebra-terms you would say 'index', but since it is only for ES 'search-field' is better ; 'index' is completely different thing in ES).

Are you experiencing different behavior?

It works, but the implementation is very different. With *NumbersPreferPhrase we only change templates and use another index when a specific search option is selected. Your patch works on a different level. :) But it's ok, we leave it like that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 --- Comment #21 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Katrin Fischer from comment #19)

It works, but the implementation is very different. With *NumbersPreferPhrase we only change templates and use another index when a specific search option is selected. Your patch works on a different level. :) But it's ok, we leave it like that.

Yes, but the situation here is different. In Zebra since always both valid and invalid ISBN was covered with ISBN (@attr 1=7) index. In ES, initially, I wanted to have the same, to have ES imitate the 'classic' Zebra behavior--the implementation would be simpler (just a correction to mappings.yaml). But then there was this discussion at Hackfest ("some libraries deliberately want to find records with only 020 $a with ISBN-search"): it was about ES, nobody wanted to touch Zebra. Hence this implementation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #22 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Added to Koha Manual. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Bug 36798 depends on bug 36574, which changed state. Bug 36574 Summary: Canceled/invalid ISBN not indexed for MARC21 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.