https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 164667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164667&action=edit Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21 For MARC 21, canceled/invalid ISBNs (subfield 020 $z) are not being indexed in Elasticsearch (search fields identifier-standard and isbn), but it is for UNIMARC (subfield 010 $z). As a result, a user searching for such an ISBN (e.g. with wrong checksum--and therefor put in 020 $z) will not find the record in the catalogue. Test plan ========= 0. Have a test installation with Elasticsearch. 1. In ktd with its test data, make a biblio search for a cancelled ISBN e.g. 9780007269854. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 3. Repeat the test. You should get "The ice princess / Camilla Läckberg". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 164778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164778&action=edit Revert "Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21" This reverts commit 019e80dbbeaccfae732c59c5590da6e5a29f329b. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- (In reply to Roman Dolny from comment #2)

Created attachment 164778 [details] [review] Revert "Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21"

This reverts commit 019e80dbbeaccfae732c59c5590da6e5a29f329b.

Janusz, sorry for canceling the commit. My mistake while trying to sign the patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164667|0 |1 is obsolete| | --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 164799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164799&action=edit Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21 For MARC 21, canceled/invalid ISBNs (subfield 020 $z) are not being indexed in Elasticsearch (search fields identifier-standard and isbn), but it is for UNIMARC (subfield 010 $z). As a result, a user searching for such an ISBN (e.g. with wrong checksum--and therefor put in 020 $z) will not find the record in the catalogue. Test plan ========= 0. Have a test installation with Elasticsearch. 1. In ktd with its test data, make a biblio search for a cancelled ISBN e.g. 9780007269854. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 3. Repeat the test. You should get "The ice princess / Camilla Läckberg". Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Janusz Kaczmarek <januszop@gmail.com> --- *** Bug 36726 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164807|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 165956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165956&action=edit Bug 36574: Canceled/invalid ISBN not indexed by ES for MARC 21 For MARC 21, canceled/invalid ISBNs (subfield 020 $z) are not being indexed in Elasticsearch (search fields identifier-standard and isbn), but it is for UNIMARC (subfield 010 $z). As a result, a user searching for such an ISBN (e.g. with wrong checksum--and therefor put in 020 $z) will not find the record in the catalogue. A new isbn-all Elasticsearch search field 'isbn-all' has been created with 020az (MARC 21, and 010az for UNIMARC), 010z has been removed from isbn search field for UNIMARC, and 020z has been added to identifier-standard search field. Test plan ========= 0. Have a test installation with Elasticsearch. 1. In ktd with its test data, make a biblio search for a cancelled ISBN e.g. 9780007269854. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 3. Repeat the test. You should get "The ice princess / Camilla Läckberg". Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 [Bug 36798] Ability to search across all ISBNs using the ISBN-search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Canceled/invalid ISBN not |Canceled/invalid ISBN not |indexed by ES for MARC 21 |indexed for MARC21 Text to go in the| |This adds a new search release notes| |index `isbn-all` to the | |default Elasticsearch | |search mappings that | |includes the valid, | |canceled and invalid ISBNs. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36574 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.