[Bug 11737] New: Use new DataTables include in quotes management template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Bug ID: 11737 Summary: Use new DataTables include in quotes management template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/quotes.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 11720 The quotes management template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25182&action=edit Bug 11737 - Use new DataTables include in quotes management template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes management page. To test you should have a multiple quotes in your database. Apply the patch and view the quotes manager page (tools/quotes.pl). Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by merlissia <manuelimel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25182|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 25188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25188&action=edit Bug 11737 - Use new DataTables include in quotes management template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes management page. To test you should have a multiple quotes in your database. Apply the patch and view the quotes manager page (tools/quotes.pl). Confirm that table sorting works correctly. Signed-off-by: merlissia <manuelimel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25188|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25192&action=edit Bug 11737 - Use new DataTables include in quotes management template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes management page. To test you should have a multiple quotes in your database. Apply the patch and view the quotes manager page (tools/quotes.pl). Confirm that table sorting works correctly. Signed-off-by: merlissia <manuelimel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25193&action=edit Bug 11737: (follow-up) fnReloadAjax.js is duplicated the file dataTables.fnReloadAjax.js exists in the interface and themelang directories. It is only used in quotes.tt. So the unused one can be removed. test plan: git grep fnReloadAjax.js should return only 1 ref (quotes.tt) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11737 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org