[Bug 11670] New: Remove sorting from patron lists action columns
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Bug ID: 11670 Summary: Remove sorting from patron lists action columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The table that lists patron lists has sortable columns for add, edit, and delete buttons. These columns should not be sortable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25009&action=edit Bug 11670 - Remove sorting from patron lists action columns The list of patron lists has sortable columns for the add, edit, and delete buttons. These columns should not be sortable. This patch removes sorting. This patch also adds the "btn-mini" class to the in-table buttons to make the table more compact. To test you must have existing patron lists. Apply the patch and navigate to Tools -> Patron lists. The columns containing the add, edit, and delete buttons should not be sortable. Other columns should sort correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25009|0 |1 is obsolete| | --- Comment #2 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- Created attachment 25050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25050&action=edit Bug 11670 - Remove sorting from patron lists action columns The list of patron lists has sortable columns for the add, edit, and delete buttons. These columns should not be sortable. This patch removes sorting. This patch also adds the "btn-mini" class to the in-table buttons to make the table more compact. To test you must have existing patron lists. Apply the patch and navigate to Tools -> Patron lists. The columns containing the add, edit, and delete buttons should not be sortable. Other columns should sort correctly. --------------------------------------------------------------------- Created to patron lists and confirmed the collums 'add patrons', 'edit' and 'delete' are no longer sortable. Column 'Name' and 'Patrons in list' are still sortable. The size of buttons are smaller. I also agree this is an improvement. Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |boutrosboutrosboutros@gmail | |.com --- Comment #3 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- Sorry, a few typos there, should be Created TWO patron lists and confirmed the COLUMNS ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25050|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25136&action=edit Bug 11670 - Remove sorting from patron lists action columns The list of patron lists has sortable columns for the add, edit, and delete buttons. These columns should not be sortable. This patch removes sorting. This patch also adds the "btn-mini" class to the in-table buttons to make the table more compact. To test you must have existing patron lists. Apply the patch and navigate to Tools -> Patron lists. The columns containing the add, edit, and delete buttons should not be sortable. Other columns should sort correctly. --------------------------------------------------------------------- Created to patron lists and confirmed the collums 'add patrons', 'edit' and 'delete' are no longer sortable. Column 'Name' and 'Patrons in list' are still sortable. The size of buttons are smaller. I also agree this is an improvement. Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11670 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org