[Bug 12521] New: Arrangement of divs on opac-advsearch.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Bug ID: 12521 Summary: Arrangement of divs on opac-advsearch.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Was having a talk with one of our designers here, she had a concern about the div-happiness of the advanced search page. I had a look, and tend to agree with her - without so many container-fluids, and putting everything in the main div, the page is easier to style. The extra container-fluid divs seem superfluous - they don't have extra classes on them for targeting with CSS. The page is broken up in a rather strange way - while talking with her I realised that I had simply gotten used to the way it looks, and hadn't given it any thought at all that it could be different or better. The attached patch I have run past her, and she finds it more pleasing to style than the old structure. The patch doesn't change any functionality - only layout. I'd especially like to hear from Owen on this, please. :) Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 29461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29461&action=edit Bug 12521 - Change layout a bit of the opac advanced search To test: Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 30149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30149&action=edit [Signed-off] Bug 12521 - Change layout a bit of the opac advanced search To test: Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid. Patch behaves as expected. Advanced search looks much better now. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29461|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #3 from mathieu saby <mathsabypro@gmail.com> --- Hello Has anybody ran a UX survey on this page? I have always thought this page was rather unfriendly for average users, but no real proof of that. Mathieu Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Not that I am aware of. Generally, a UX survey of the OPAC would be a good thing to do. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org Assignee|oleonard@myacpl.org |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12697 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30823&action=edit [PASSED QA] Bug 12521 - Change layout a bit of the opac advanced search To test: Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid. Patch behaves as expected. Advanced search looks much better now. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked visually and with HTML validator. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org