[Bug 17470] New: overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Bug ID: 17470 Summary: overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: theod@lib.auth.gr QA Contact: testopia@bugs.koha-community.org If patron P has two overdue items: I1 from branch B1 and I2 from branch B2, then overdue_notices.pl will produce two emails coming from B1 and B2 that have the same list of BOTH items I1 AND I2 in BOTH emails. I believe that this is not an intended behavior and that each email coming from each branch should show overdue items belonging to that respective branch only. Steps to reproduce: 0/ Have (or create) at least two branches B1 and B2 1/ Make sure you're logged in with an account belonging to B1, or switch to branch B1 2/ checkout item I1 (belonging to B1) to patron P (preferably while specifying a due date < today) 3/ switch to branch B2 4/ checkout item I2 (belonging to B2) to patron P (preferably while specifying a due date < today) 5/ make sure you have defined "Overdue notice/status triggers" for that patron category, ie with Delay=1 so that "Overdue Notice" is selected and "Email" is checked. 6/ from cli run 'perl ./misc/cronjobs/overdue_notices.pl' (optionally specifying also '-library B1 -library B2') 7/ (at least) two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items 8/ either see the 'content' field in these entries, or run 'perl ./cronjobs/process_message_queue.pl' to receive the actual emails (provided the email is properly setup) I have verified the same behavior with versions 3.20.x, 3.22.x and master (but must also apply to all recent Koha versions). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod@lib.auth.gr Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 57298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57298&action=edit Bug 17470 Make overdue notices according to branch item only As a test plan I redirect you to the steps described by Theodoros : 1) do these steps 2) apply the patch 3) redo them. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 --- Comment #2 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- Thank you Olivier for the patch! I can verify that the patch works as expected for 3.20 and master. Having said that, I leave it as 'Needs Signoff'. Maybe @Kyle or someone from QA team could/should sign it off? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Theodorus, if it works for you on master, please sign off! The QA team will take over from there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57298|0 |1 is obsolete| | --- Comment #4 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 57429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57429&action=edit Bug 17470 Make overdue notices according to branch item only I replaced the "items.homebranch" chunk in the sql query by "issues.branchcode" which I think is a better choice considered the fact that the holdingbranch is more likely to do the claim. I must add that we can observe the same behaviour described by Theodoros with the library option and this patch deals with it as well : if you have 2 branches, say A et B, and a claim of same delay on them, by now you get 2 messages. it's Ok, but both of them list also the claimed item of the other one. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The patch that has been signoff is not the one that is attached now. Another signoff is required. Please provide a complete test plan to make sure the tester will test all the different cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 --- Comment #6 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Test plan 0/ Have (or create) at least two branches B1 and B2 1/ Make sure you're logged in with an account belonging to B1, or switch to branch B1 2/ checkout item I1 (belonging to B1) to patron P while specifying a due date < today) 3/ switch to branch B2 4/ checkout item I2 (belonging to B2) to patron P while specifying a due date < today) 5/ make sure you have defined "Overdue notice/status triggers" for that patron category, ie with Delay=1 so that "Overdue Notice" is selected and "Email" is checked. 6/ from cli run 'perl ./misc/cronjobs/overdue_notices.pl' 7/ two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items 8/ either see the 'content' field in these entries, or run 'perl ./cronjobs/process_message_queue.pl' to receive the actual emails (provided the email is properly setup) 9) run again overdue_notices.pl with library option for both B1 and B2 (you must give the branchcode as parameter) like this : ./overdue_notices.pl -t -library B1branchcode -library B2branchcode 10) see again that the generated messages have the same list of overdue items 11) apply the patch 12) run again the script first without library option and secondly with it : in both cases, 2 messages will be created. One from B1 claiming the B1 item, another from B2 claiming the B2 item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57429|0 |1 is obsolete| | --- Comment #7 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- Created attachment 57791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57791&action=edit Bug 17470 Make overdue notices according to branch item only When a patron had overdues on items from different branches he received from each corresponding branch a notice claiming the complete list of these items. Signed-off-by: sbujam <sbujam@users.noreply.github.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57791|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58116&action=edit Bug 17470 Make overdue notices according to branch item only When a patron had overdues on items from different branches he received from each corresponding branch a notice claiming the complete list of these items. Signed-off-by: sbujam <sbujam@users.noreply.github.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |koha@univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Olivier! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Severity|normal |enhancement Status|Pushed to Master |RESOLVED --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am hesitating to push this to stable as it's a change in behavior and might come as a surprise. I think this would be better in a feature release with information added to the field for the release notes documentation. I am changing this to an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17649 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Jason Palmer <jpalmer@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpalmer@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11761 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org