[Bug 40250] New: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Bug ID: 40250 Summary: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I noticed while translating that the link to the NoIssuesChargeGuarantorsWithGuarantees syspref in the patron category settings page is a link to NoIssuesChargeGuarantees. A simple copy-paste error I think. To recreate: 1. Go to Administration > Patron categories 2. Click New category --> Notice the hint under "Guarantors with guarantees checkout charge limit" is to the NoIssuesChargeGuarantees system preference rather than NoIssuesChargeGuarantorsWithGuarantees -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 183547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183547&action=edit Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page This patch corrects the link to the NoIssuesChargeGuarantorsWithGuarantees system preference in the patron category creation/modification page. To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hint under 'Guarantors with guarantees checkout charge limit' links to the correct system preference 5. Click on the link and make sure it links to the correct system preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 183548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183548&action=edit Bug 40250: Terminology changes 'preference' to 'system preference' This patch corrects the terminology used in the patron category settings page, changing 'preference' to 'system preference'. https://wiki.koha-community.org/wiki/Terminology#P To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hints under 'Checkout charge limit', 'Guarantees checkout charge limit', and 'Guarantors with guarantees checkout charge limit' use 'system preference' and not 'preference' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I also added a patch to correct terminology. We should use 'system preference', not 'preference' https://wiki.koha-community.org/wiki/Terminology#P Let me know if I should move this to a different bug report... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183547|0 |1 is obsolete| | Attachment #183548|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183554&action=edit Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page This patch corrects the link to the NoIssuesChargeGuarantorsWithGuarantees system preference in the patron category creation/modification page. To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hint under 'Guarantors with guarantees checkout charge limit' links to the correct system preference 5. Click on the link and make sure it links to the correct system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183555&action=edit Bug 40250: Terminology changes 'preference' to 'system preference' This patch corrects the terminology used in the patron category settings page, changing 'preference' to 'system preference'. https://wiki.koha-community.org/wiki/Terminology#P To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hints under 'Checkout charge limit', 'Guarantees checkout charge limit', and 'Guarantors with guarantees checkout charge limit' use 'system preference' and not 'preference' Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183554|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183587&action=edit Bug 40250: Wrong link to NoIssuesChargeGuarantorWithGuarantees in patron category page This patch corrects the link to the NoIssuesChargeGuarantorsWithGuarantees system preference in the patron category creation/modification page. To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hint under 'Guarantors with guarantees checkout charge limit' links to the correct system preference 5. Click on the link and make sure it links to the correct system preference Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183555|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183588&action=edit Bug 40250: Terminology changes 'preference' to 'system preference' This patch corrects the terminology used in the patron category settings page, changing 'preference' to 'system preference'. https://wiki.koha-community.org/wiki/Terminology#P To test: 1. Apply patch 2. Go to Administration > Patron categories 3. Click 'New category' 4. Check that the hints under 'Checkout charge limit', 'Guarantees checkout charge limit', and 'Guarantors with guarantees checkout charge limit' use 'system preference' and not 'preference' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the link to the release notes| |system preference | |NoIssuesChargeGuarantorsWit | |hGuarantees when creating | |or editing a patron | |category. Previously, the | |link erroneously pointed to | |the | |NoIssuesChargeGuarantees | |system preference. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Code in 24.11.x is quite different, not sure this applies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40250 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to document. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org