[Bug 40061] New: Cannot delete image from patron card creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Bug ID: 40061 Summary: Cannot delete image from patron card creator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org I noticed this in 24.05, but it also happens in KTD on main. When you upload an image in the patron card creator, if you try to delete it, it returns an error. 1. Go to Tools > Patron card creator 2. Click New > Image 3. Upload an image (I used a png with transparent background, hence why I had to delete it after, but I also tried with a jpg with the same result) 4. Enter a name for the image (I tried "Logo Bibliothèque" as well as a name all in lowercase letters without spaces or diacritics "tomhanks" with the same result) 5. Click Upload 6. Click Delete on the right-hand side --> Error "WARNING: An error has occurred. Please have your system administrator check the error log for details." plack-intranet-error.log says [2025/06/03 16:40:36] [WARN] No image ids passed in to delete. at /kohadevbox/koha/patroncards/image-manage.pl line 131. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |oleonard@myacpl.org |u | Status|NEW |ASSIGNED Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182946&action=edit Bug 40061: Add CSRF protection to patron image deletion The patron image deletion operation was not fully updated in Bug 34478. The individual "Delete" buttons in the table of images need to be updated to use form-submit.js Unrelated: I removed an invalid "align" attribute from a <td>. To test, apply the patch and go to Tools -> Patron card creator -> Image manager. - Upload multiple images - Test the individual "Delete" buttons in the table of images. - Test that both the "OK" and "Cancel" operations work correctly. - Test the process of checking one or more checkboxes and clicking the "Delete selected" button. - Test that both the "OK" and "Cancel" operations work correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Owen! The Delete button works now. I know it wasn't part of the original bug report, but I also tested the checkbox + Delete selected button, and for some reason, when I try to delete the last image this way, it's not deleted...? If there is one image, and you check it and click Delete selected, it's not deleted. If there is more than one and you check one or more, they are deleted. Is it the same problem? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182957&action=edit Bug 40061: (follow-up) Delete last image using checkbox This followup corrects a problem in image deletion which isn't really the same issue (it's not CSRF related) but is another problem with deletion. The JS for grabbing all the checkboxes by name wasn't working when there is only one checkbox. To test, apply the patch and delete all but one image from the patron card creator image manager. - Check the checkbox for the last image and click the "Delete selected" button. - The image should be deleted successfully. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Caroline Cyr La Rose from comment #2)
Is it the same problem?
Technically not the same problem but it makes sense to me to include the fix here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182946|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 182959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182959&action=edit Bug 40061: Add CSRF protection to patron image deletion The patron image deletion operation was not fully updated in Bug 34478. The individual "Delete" buttons in the table of images need to be updated to use form-submit.js Unrelated: I removed an invalid "align" attribute from a <td>. To test, apply the patch and go to Tools -> Patron card creator -> Image manager. - Upload multiple images - Test the individual "Delete" buttons in the table of images. - Test that both the "OK" and "Cancel" operations work correctly. - Test the process of checking one or more checkboxes and clicking the "Delete selected" button. - Test that both the "OK" and "Cancel" operations work correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182957|0 |1 is obsolete| | --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 182960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182960&action=edit Bug 40061: (follow-up) Delete last image using checkbox This followup corrects a problem in image deletion which isn't really the same issue (it's not CSRF related) but is another problem with deletion. The JS for grabbing all the checkboxes by name wasn't working when there is only one checkbox. To test, apply the patch and delete all but one image from the patron card creator image manager. - Check the checkbox for the last image and click the "Delete selected" button. - The image should be deleted successfully. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Perfect! Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182959|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183039&action=edit Bug 40061: Add CSRF protection to patron image deletion The patron image deletion operation was not fully updated in Bug 34478. The individual "Delete" buttons in the table of images need to be updated to use form-submit.js Unrelated: I removed an invalid "align" attribute from a <td>. To test, apply the patch and go to Tools -> Patron card creator -> Image manager. - Upload multiple images - Test the individual "Delete" buttons in the table of images. - Test that both the "OK" and "Cancel" operations work correctly. - Test the process of checking one or more checkboxes and clicking the "Delete selected" button. - Test that both the "OK" and "Cancel" operations work correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182960|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183040&action=edit Bug 40061: (follow-up) Delete last image using checkbox This followup corrects a problem in image deletion which isn't really the same issue (it's not CSRF related) but is another problem with deletion. The JS for grabbing all the checkboxes by name wasn't working when there is only one checkbox. To test, apply the patch and delete all but one image from the patron card creator image manager. - Check the checkbox for the last image and click the "Delete selected" button. - The image should be deleted successfully. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36192 Text to go in the| |This fixes deleting patron release notes| |images in the patron card | |creator (Tools > Patrons | |and circulation > Patron | |card creator > +New Image). | | | | | |Deleting images now works: | |- using the delete button | |beside each image | |- using the checkbox to | |select and delete the last | |image, if there is only one | |image | | | |(This is partly related to | |the CSRF changes added in | |Koha 24.05 to improve form | |security.) CC| |david@davidnind.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Trying to backport on 24.11 for 24.11.06 but it appears the test plan does not work on top of 24.11.x. The patch deletes the behaviour on click for the .delete_image buttons and use data-* tags instead. This might not be present on 24.11 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Cant reproduce in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40061 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to document. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org