[Bug 28508] New: Use "Invoice number" instead of "Invoice no" on the invoice search filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Bug ID: 28508 Summary: Use "Invoice number" instead of "Invoice no" on the invoice search filter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org There is not much benefit to using "no" instead of "number", and it makes it less translateable and understandable. This should be fixed in three places that I can see: 1. the search filter form 2. the results table column heading 3. when there are no results, there is text that says 'Search was:' and a label that says 'Invoice no.' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121736&action=edit Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter This patch corrects instances of the abbreviated phrase "Invoice no." from the templates, making it "Invoice number." Also corrected: An instance of "Bookseller" is replaced with "Vendor." To test, apply the patch and confirm that the phrase is correct in these cases: - Acquisitions -> Invoices: Check the "Search filters" form in the left-hand sidebar. -> View an invoice: Check the label in the form. - Acquisitions -> Vendor -> Receive shipments: Check the table of invoices. - Acquisitions -> Orders search (in the search header) -> Advanced search: Check the labels in the form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Salman Ali <salman.ali@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121736|0 |1 is obsolete| | --- Comment #2 from Salman Ali <salman.ali@inLibro.com> --- Created attachment 121796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121796&action=edit Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter This patch corrects instances of the abbreviated phrase "Invoice no." from the templates, making it "Invoice number." Also corrected: An instance of "Bookseller" is replaced with "Vendor." To test, apply the patch and confirm that the phrase is correct in these cases: - Acquisitions -> Invoices: Check the "Search filters" form in the left-hand sidebar. -> View an invoice: Check the label in the form. - Acquisitions -> Vendor -> Receive shipments: Check the table of invoices. - Acquisitions -> Orders search (in the search header) -> Advanced search: Check the labels in the form. Signed-off-by: Salman Ali <salman@outaouais> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Salman Ali <salman.ali@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |salman.ali@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121796|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121921&action=edit Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter This patch corrects instances of the abbreviated phrase "Invoice no." from the templates, making it "Invoice number." Also corrected: An instance of "Bookseller" is replaced with "Vendor." To test, apply the patch and confirm that the phrase is correct in these cases: - Acquisitions -> Invoices: Check the "Search filters" form in the left-hand sidebar. -> View an invoice: Check the label in the form. - Acquisitions -> Vendor -> Receive shipments: Check the table of invoices. - Acquisitions -> Orders search (in the search header) -> Advanced search: Check the labels in the form. Signed-off-by: Salman Ali <salman.ali@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Note: I fixed Salman's SO line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org